Conversation
FJanssen-TNO
requested review from
KobusVanRooyen and
jimrojerTNO
as code owners
| self.index = index | ||
|
|
||
| self.targets = target | ||
| # self.target_min = target[0].values[index] |
There was a problem hiding this comment.
Should the commented out code be deleted? Else add a small note why this commented out code should not be deleted
| vector_state = ( | ||
| nom * optimization_problem.state_vector(self.state, ensemble_member)[self.index] | ||
| ) | ||
| # self.target_min = self.targets[ensemble_member].values[self.index] |
There was a problem hiding this comment.
Should the commented out code be deleted? Else add a small note why this commented out code should not be deleted
|
|
||
|
|
||
| class _GoalsAndOptions: | ||
| # def path_goals(self): |
There was a problem hiding this comment.
Should the commented out code be deleted? Else add a small note why this commented out code should not be deleted
|
|
||
| # check that the ensemble size is set at 2, which is based on the ensemble.csv | ||
| np.testing.assert_equal(problem.ensemble_size, 2) | ||
| prob_0 = problem.ensemble_member_probability(0) |
There was a problem hiding this comment.
You are referring to problem 0, 1, 2 ...... Also in the loop below e_m starts at 0, ...3, 4 (in the future). But the ensemble names are indexed from 1 onwards -> forecast1, forecast2 . I woud suggest that we start defining the standard that all of these should start with index 0 to makes things more clean and to prevent confusions in the future with indexing or numbers. What do you think?
Also can we need rather create a definition that the names should have an underscore between the name and number, for instance forecast_1, .... ? I know there might not always be a number included in the name, but if we use use numbers to use this method/definition?
2 participants
No description provided.