Open
Conversation
KobusVanRooyen
requested review from
FJanssen-TNO and
jimrojerTNO
as code owners
Collaborator
Author
|
@FJanssen-TNO ready for review. Main problem is that pkg_resources (required by rtctools) has been removed in v82.0.0 of setuptools. Pandapipes and rtctools have different limitations re setuptools |
Collaborator
FJanssen-TNO
left a comment
FJanssen-TNO
left a comment
There was a problem hiding this comment.
Only one questions, afterwards I'll approve.
| flake8-comprehensions == 3.15.0 | ||
| flake8-import-order == 0.18.2 | ||
| pep8-naming == 0.13.3 | ||
| setuptools == 80.9.0 |
Collaborator
There was a problem hiding this comment.
why do we need to mention it here in the test_env_main_1 again? If it isalready in setup.py it should be sufficient, or is it not?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.