Fabricated Overlays Backend Support.#1575
Fabricated Overlays Backend Support.#1575Tharow wants to merge 8 commits intoMuntashirAkon:masterfrom
Conversation
Signed-off-by: Theray Tharow <tharowt@tharow.net>
Very Imcomplete Signed-off-by: Theray Tharow <tharowt@tharow.net>
Fix setOwningPackage as documentation about it lies. make AppDetailsOverlaysFragment.java use transaction system on newer systems as it allows changing of the new fabricatedOverlays. TODO: setup FabOverlay deletion. TODO: flesh out OverlayManagerCompact.FabricatedOverlayBuilder Signed-off-by: Theray Tharow <tharowt@tharow.net>
Signed-off-by: Theray Tharow <tharowt@tharow.net>
There was a problem hiding this comment.
For generated classes, it's better if you only include the required fields. Note that you may not want to add final to fields since finals (constants) will be unfolded during compilation.
There was a problem hiding this comment.
Will be sure to do that before undrafting the pr.
|
@MuntashirAkon I apologize for the slow updates to this, it has been a lot of work, and the public doc's are complete lies. the doc for setOwningPackage a fine example of the problem. The other more difficult issue is the rewrite due to overlaymanager having annoying defaults for creation when it sends it off to the idmap service. So when we need to the builder allows bypassing of all restrictions assoc'd with the overlaymanager as it directly interacts with idmap2 and some daemon nonsense on top of it. to deal with the fact that we can't leave it running nor is it running by default. Idmap is what converts Res Numbers to res and it was directly handles how overlays are "loaded" (converted to @idmap) then loaded by assetmanager but still. But i should be able to post an update to it soon. |
Signed-off-by: Theray Tharow <tharowt@tharow.net>
|
Please take your time. We're not in a hurry on this. Public docs in the AOSP are frequently outdated or simply absent. |
…fabricatedoverlays. IdmapDaemon.java allows use of the idmap service directly which will be required at a later date. Signed-off-by: Theray Tharow <tharowt@tharow.net>
Signed-off-by: Theray Tharow <tharowt@tharow.net>
2 participants
TODO:
References: Add Fabricated Overlays to OMS
Functional Details:
Any Fabricated Overlay owned by the current shell android.R.string.config_systemShell will be removed during init of the OverlayManagerService.
Fabricated Overlays have to be owned by a package allowed to overlay it, via OverlayConfig, this is worked around by setting the owner to the android package.
FabricatedOverlayBuilder
The Internal Builder for FabricatedOverlay requires advanced knowledge to use. the builder greatly simplify the adding of resources to the overlay.
Fuctionality