-
Notifications
You must be signed in to change notification settings - Fork 3
'ProcessingLevel/ProcessingLevelDescription' #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Describe the bug: PyQuARC did not flag the collection ProcessingLevel/ProcessingLevelDescription with or without the ProcessingLevel/Id. If the processing level is available [0, 1A, 1B, 1C, 2 or 3], the processing level description is checked for the characters. If the characters are less than 50, then an info message is generated. To reproduce: Example: C1602481912-CDDIS -ProcessingLevel/ProcessingLevelDescription < 50 and info message (blue). Expected behavior: Any collection record, irrespective of the number of characters, should provide the details for the processing level description. |
|
Works on CDDIS record. The following records were used for the testing: C179014695-NSIDC_ECS - For this record, PyQuARC flags the processing level description with an error message saying that the characters are less than 50. This is still in consistency with other records where the processing level description is required. We are not sure if the error message has to be consistent. ? |
|
Before merging the changes in this PR, please double-check the following: Processing Level Description:
Processing Level Id Hold off on making any changes to the error message that appears for the "ProcessingLevel / Id" element. We're currently waiting for ESDIS to confirm the correct formatting that should be recommended both in our manual curation process and in pyQuARC (e.g., "Level 0" vs. "Level0" vs. "0"). |
|
Update on Processing Level Id: We heard back from ESDIS, and they confirmed that the correct formatting for the Processing Level Id is as follows: [0, 1A, 1B, 1C, 2, 2A, 2B, 3, 3A, 4]. For example, entries such as "Level 0" or "Level0" are not valid; instead, the value should simply be "0". For more, please refer to KMS controlled vocabulary schema. |
…MPACT/pyQuARC into feature-add_new_checks-la
|
Moved changes to the new PR #323, hence closing this PR. |
A new feature 'ProcessingLevel/ProcessingLevelDescription' rule (Check #549) has be added.