Skip to content

Conversation

@lavanya3k
Copy link
Collaborator

A new feature 'ProcessingLevel/ProcessingLevelDescription' rule (Check #549) has be added.

@lavanya3k lavanya3k requested a review from smk0033 January 29, 2025 20:50
@lavanya3k
Copy link
Collaborator Author

lavanya3k commented Feb 10, 2025

Describe the bug: PyQuARC did not flag the collection ProcessingLevel/ProcessingLevelDescription with or without the ProcessingLevel/Id. If the processing level is available [0, 1A, 1B, 1C, 2 or 3], the processing level description is checked for the characters. If the characters are less than 50, then an info message is generated.
The above bug fix works when the correct processing level is present. But, to be consistent in the error message, ProcessingLevel/ProcessingLevelDescription needs to be updated when the characters are under 50, and blue info warning.

To reproduce: Example: C1602481912-CDDIS -ProcessingLevel/ProcessingLevelDescription < 50 and info message (blue).
C2043197582-CDDIS umm-c format - Info message for ProcessingLevel/ProcessingLevelDescription.
C1000000005-CDDIS umm-c format - Works correct.

Expected behavior: Any collection record, irrespective of the number of characters, should provide the details for the processing level description.

@lavanya3k lavanya3k requested a review from bhawana11 March 7, 2025 18:26
@bhawana11
Copy link
Collaborator

Works on CDDIS record. The following records were used for the testing:
C1000000042-CDDIS
C1000000006-CDDIS
C2043197582-CDDIS
C1291967305-CDDIS
C2978524117-CDDIS

C179014695-NSIDC_ECS - For this record, PyQuARC flags the processing level description with an error message saying that the characters are less than 50. This is still in consistency with other records where the processing level description is required. We are not sure if the error message has to be consistent. ?
Another issue with the collection ID - PyQuARC flags the processing level ID [‘Level 3’] as a yellow flag, but this was not flagged in the CMR Dashboard. According to EOSDIS, processing level IDs are in the following format [0, 1A, 1B, 1C, 2, 2A, 2B, 3, 3A, 4.

@FBayat021
Copy link

FBayat021 commented Apr 17, 2025

Before merging the changes in this PR, please double-check the following:

Processing Level Description:

Processing Level Id

Hold off on making any changes to the error message that appears for the "ProcessingLevel / Id" element. We're currently waiting for ESDIS to confirm the correct formatting that should be recommended both in our manual curation process and in pyQuARC (e.g., "Level 0" vs. "Level0" vs. "0").

@FBayat021
Copy link

Update on Processing Level Id: We heard back from ESDIS, and they confirmed that the correct formatting for the Processing Level Id is as follows: [0, 1A, 1B, 1C, 2, 2A, 2B, 3, 3A, 4]. For example, entries such as "Level 0" or "Level0" are not valid; instead, the value should simply be "0". For more, please refer to KMS controlled vocabulary schema.

@lavanya3k
Copy link
Collaborator Author

Moved changes to the new PR #323, hence closing this PR.

@lavanya3k lavanya3k closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants