Skip to content

Conversation

@lavanya3k
Copy link
Collaborator

@lavanya3k lavanya3k commented Jun 3, 2025

Description of the PR - This is code change for the EntryTitle error. If the EntryTitle is similar to the Shortname with special characters '-' between the words, then PyQuARC should flag for the error. The entry title has to be detailed and should NOT be the same as a short name.

For the Entrytitle, the code changes are made in the string_validator.py and check_messages_override.json. Further, we updated the outdated files in the test_downloader.py and schema_validator.py. There was an outdated imports DraftValidator, and this has to be updated before every commit. The final code is test by running pytest, and the run was successful before committing the code changes.

To Reproduce
C1000000003-CDDIS --format umm-c
C1000000004-CDDIS --format umm-c
C1000000012-CDDIS --format umm-c

Expected behavior
EntryTitle and ShortName - PyQuARC should flag as a bug (RED) if the characters in the EntryTitle and ShortName are the same.
Screenshot 2025-06-03 at 12 13 33 PM

@FBayat021
Copy link

For this concept ID C1000000010-CDDIS, the expected error message for EntryTitle doesn't show up. Please address before pushing to the dev/master.

@lavanya3k
Copy link
Collaborator Author

For the concept ID C1000000010-CDDIS, the EntryTitle has been updated, and it differs from the ShortName. Reference: https://cmr.earthdata.nasa.gov/search/concepts/C1000000010-CDDIS.native. Due to the update on the Earthdata Search, we do not see the error flag for this record.

@lavanya3k
Copy link
Collaborator Author

Tested on a fake file, and the EntryTitlecheck works. See below for replicating the error for collection ID C1000000022-CDDIS.
Screenshot 2025-08-15 at 6 59 26 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this in check_messages

@lavanya3k lavanya3k merged commit 7939bdc into dev Oct 16, 2025
1 check passed
@lavanya3k lavanya3k mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants