Skip to content

Conversation

@bhawana11
Copy link
Collaborator

This is a pull request for issue #324 url_description_uniqueness_check (Granule).

Expected outcome:
The PyQuARC error at the bottom of the results page with the following message
'ERROR: Running check for the rule: 'url_description_uniqueness_check' failed.. Details: sequence item 0: expected str instance, NoneType found' should not be seen.

Code Changes:
Added a override for 'url_description_uniqueness_check" in rules_override.json file.

To Reproduce:
Example concept ID: G2693552851-CDDIS (umm-g)

@bhawana11 bhawana11 requested a review from lavanya3k June 11, 2025 17:24
@bhawana11 bhawana11 requested a review from slesaad July 3, 2025 15:50
@lavanya3k
Copy link
Collaborator

Check for the granule G1811369774-CDDIS (umm-g)

@lavanya3k lavanya3k changed the base branch from master to dev August 7, 2025 20:24
@lavanya3k
Copy link
Collaborator

Description of the fix: The above code changes were reviewed and tested on umm-g and echo-g granules. The error url_description_uniqueness_check existed for the umm-c schema, and it was not resolved. Additionally, there was a similar error, online_access_description_uniqueness_check, for the echo-g schema.
The code changes are made in the rule_mapping.json and tested for quality control.

Output: You will NOT see the PyQuARC errors when it is run for Granules (umm-c and echo-g)
ERROR: Running check for the rule: 'url_description_uniqueness_check' failed
ERROR: Running check for the rule: 'online_access_description_uniqueness_check' failed.

Granules tested:
G1811369774-CDDIS --format umm-g
G1792338802-CDDIS --format umm-g
G2693552851-CDDIS --format umm-g
G2488091813-CDDIS --format echo-g
G1763305132-CDDIS --format echo-g

@lavanya3k
Copy link
Collaborator

@slesaad - Can you ignore the code changes from schema_validator.py due to conflicts from other local branches?

@lavanya3k lavanya3k merged commit 82ee541 into dev Oct 15, 2025
1 check passed
@lavanya3k lavanya3k mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants