Closed
Conversation
Author
|
I don't think I can request reviewers, but tagging @djgagne here. @kevinyang-cky and I sorted this out this morning. And here's a CI run on my fork that shows this passing in case that's helpful: https://github.com/kafitzgerald/bridgescaler/actions/runs/21724800653 |
Collaborator
|
Thank you @kafitzgerald for helping out with the testing. We have decided to adapt the edits here into #23 and close this one here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to get a working environment with uv and CI passing again, we need to pin these two dependencies.
Newer version of NumPy aren't supported by Numba, but install anyway and then break stuff if we don't have the version pin.
And then Pandas 3 and newer will break Bridescaler at the moment (test suite fails) so we should pin that until it's addressed.