bugfix: prevent image loading crash when actual channel is not three#87
Open
r1ckhu wants to merge 1 commit intoNJUCG:mainfrom
Open
bugfix: prevent image loading crash when actual channel is not three#87r1ckhu wants to merge 1 commit intoNJUCG:mainfrom
r1ckhu wants to merge 1 commit intoNJUCG:mainfrom
Conversation
Fix an issue in the stbi_loadf and stbi_load functions where the last parameter was incorrectly set to three. This caused the "data" array to always have three channels, rather than the expected "c" channels.
Contributor
Author
|
The stb_image documentation for reference. |
Contributor
Author
|
Example scene that fails in the original code: https://njucg.github.io/Moer/files/bathroom.zip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue in the
stbi_loadfandstbi_loadfunctions where the last parameter was incorrectly set to three. This caused the "data" array to always have three channels, rather than the expected "c" channels.