Prevent deadlock due to lack of approve_loaded()#497
Merged
Conversation
If review is not enabled, 'approve_loaded()' was not called, causing a deadlock. The 'approve_loaded()' call has been moved so that it occurs whether review is enabled or not.
This avoids a deadlock where a new background task could be set while an earlier one was ongoing.
'BackgroundTasks' extends the 'background_task' convention across the codebase, allowing multiple background tasks to be ongoing at once. This is important to allow; there are cases where one background task spawns another. Within the current convention, the 'background_task' field would sometimes be cleared early so that new tasks could be added. 'BackgroundTasks' eliminates this manual effort by allowing multiple background tasks to coexist. It offers a nicer API that ensures that 'tracing::Span's are set to assist with logging.
bal-e
force-pushed
the
approve-loaded-deadlock
branch
from
93c9efa to
c8d87a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If review is not enabled,
approve_loaded()was not called, causing a deadlock in Cascade. Theapprove_loaded()call has been moved so that it occurs whether review is enabled or not.Thanks for catching and debugging this @ximon18!