Conversation
The zone signer code works with 'Name', not 'ParsedName', so I'm renaming the 'Old*' type aliases and adding new ones.
This allows directly setting the records from a 'Vec', making it easy to generate the records in parallel using Rayon and collect them into a 'Vec' efficiently. This is a somewhat temporary measure: in the future, we expect to use concurrent data structures for the zone storage, so 'add()' can take '&self' and be used in parallel.
ximon18
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #486, this PR contains some more miscellaneous changes I made while integrating the zone signer with the new zone storage.