Closed
Conversation
…i.e. for when domain #468 is fixed).
…mat with the original ldns-signzone.
…ashed owner names, as it's slow AND original ldns-signzone doesn't check correctly for hashes that are not orphans due to correspoding to an ENT (as it discovers ENTs _after_ rejecting orphaned hashed owner names) AND the conclusion is that original ldns-signzone should strip NSEC(3)s on load, as we previously, and again now do.
…zonefile compared to the original ldns-signzone.
…r in LDNS mode, i.e. to 3600, or to 0 to match common tooling behaviour (BIND, dnssec-signzone, and OpenDNSSEC).
…Type Bitmaps, to match RFC and original ldns-signzone behaviour.
- Use new SignableZoneInPlace trait instead of the now removed Signer. - Use new update_data() fn instead of more specific replace_soa() and replace_rrsig_for_apex_zonemd(). - Use generate_rrsigs() instead of trying to treat a single ZONEMD or a few ZONEMD RRs as a zone to be signed (which would also generate NSEC(3) and DNSKEY RRs etc). - Fix examples to have correct NSEC3PARAM TTL matching updated behaviour to use 3600 like LDNS or SOA MINIMUM otherwise.
…ing generate_rrsigs() directly, also making it clearer that we are only signing a single RRset and don't need to pass in an unused SigningConfig.
…l to sign_zone() and explicit use of ByteMut.
Philip-NLnetLabs
force-pushed
the
signer-incremental-faketime
branch
from
28cc5e6 to
25745b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're experimenting with incremental DNSSEC signing in 'dnst signer', to prepare for this fucntionality in Cascade.
Currently we can sign the changes in the .se zone between last Saturday and Sunday in 3 seconds. Loading the unsigned zone takes 6 seconds and writing out the new signed zone another 12 seconds.
For comparison, the non-incremental signer took ~35 seconds (vs 3s for incremental), even with parallelism.