Initial fuzzing support, and failing fuzz test case.#24
Initial fuzzing support, and failing fuzz test case.#24
Conversation
tertsdiepraam
left a comment
There was a problem hiding this comment.
Looks good, but I suggest that we keep this unmerged until we can make this depend on the main branch of domain.
It now depends on the |
|
Revived! Maybe a controversial change is to make the stelline feature no longer optional, but that seemed like the easiest way to do this right now since |
@tertsdiepraam: I'm afraid I don't understand what is left to do here, the PR seems to work for me in its current form. |
| "tsig", | ||
| "unstable-client-transport", | ||
| "unstable-sign", | ||
| "unstable-stelline", |
There was a problem hiding this comment.
@ximon18 this is the "controversial" change. If you agree with this then its fine with me to merge it.
There was a problem hiding this comment.
I see.
The fuzz binary uses FakeEnv which causes this problem.
Could another way be to impl Env for FuzzEnv where FuzzEnv doesn't use Stelline (and so wouldn't be suitable for running dnst update or dnst notify unless some non-Stelline based impl of Env::dgram() and Env::stub_resolver_from_confg() would be possible)?
There was a problem hiding this comment.
I wonder if we should do ldns-testns. If so then we will get stelline as well.
There was a problem hiding this comment.
Yes. We may need to rethink the name and design for the dnst version. But it seems a useful feature.
See
fuzz/README.md.Uses NLnetLabs/domain#441.