Add support for connection re-use by secondary for XFR#145
Open
saradickinson wants to merge 10 commits intoNLnetLabs:masterfrom
Open
Add support for connection re-use by secondary for XFR#145saradickinson wants to merge 10 commits intoNLnetLabs:masterfrom
saradickinson wants to merge 10 commits intoNLnetLabs:masterfrom
Conversation
Add logging
…ow. Option not yet used.
…e checkconf unit test to support new options
wcawijngaards
added a commit
that referenced
this pull request
Dec 3, 2020
does not allow new queries to be made, the connection is closed. Only existing queries and zone transfers are answered, new ones are rejected by a close of the channel.
Member
|
Instead of the |
Contributor
Author
|
I think having the default on would be good, I thought an option might be useful so it could be disabled in case of interop problems (e.g a legacy XFR implementation behind a proxy). |
Member
|
Perhaps it should be configurable per upstream then? For example in the tls-auth: declaration? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*** FOR REVIEW ONLY AT THIS TIME***
xfrd-conn-reuse(default no) andtcp-idle-timeout(default 10)xfrd-conn-reuse: yesthe secondary will utilise the existing the mechanisms in place (which are currently only used whenXFRD_MAX_TCPis exhausted) to re-use connectionstcp-idle-timeout, which is currently a fixed timeout. A later commit will add support for EDNS0 Keepalive, so the server can signal the timeout to use (as described in draft-ietf-dprive-xfr-over-tls)tpkg\long\testplan-axfr.dirtest, will send separate email about this.