-
Notifications
You must be signed in to change notification settings - Fork 13
Add new solver and options for torque tube as a spring #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eyoung55
wants to merge
25
commits into
NREL:dev_wrap
Choose a base branch
from
eyoung55:torque-spring
base: dev_wrap
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew check on z_min/max clipping
…rque tube is not specified (length zero)
…strategy (panel bottom surface = 0 (z))
…nel to the ground
…ccount for new positioning conventions
…h new meshing convention
…k to avoid dimension mismatch
The variational form should include only ufl.dx or dx_structure. It cause assertion error if we use ufl.dx and dx_structure at the same time.
we are solving the structure first. For the first step, no stress is applied to the structure, so the rotation is zero from first time step, which return nan stiffness value. Initialize the spring stiffness to zero at the first time step (or phi=0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to simulate the stiffness derived from the torque tube due to fictitious spring forces (Robin boundary conditions). Many changes are included, but in summary:
DomainCreation.pyfor the panels3d module to enablepv_array.torque_tube_separationpv_array.torque_tube_radiuspv_array.modules_per_spaninput_schema.yamlto allow new parameters with defaults that revert to the old behaviorsim_params.yamlto slightly reduce the elevation of the 3d panel consistent with defining elevation as the distance between the axis of rotation of the torque tube and the ground level.ElasticityManager.pyandStructureMain.pyhave updates to save the acceleration data at the NE corner vertex (in addition to the previously saved deformation), rename variables for clarity between deformation and acceleration, and an update to tag the correct vertex with the new mesh convention for elevation