-
Notifications
You must be signed in to change notification settings - Fork 2
[Draft]募金ページの実装 #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[Draft]募金ページの実装 #990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the campus fund donation page as part of issue #887 by adding a dedicated page that displays donation totals and facilitates teacher selection and report submission. Key changes include:
- A new campus fund page layout with interactive building selection and donation calculations.
- New components for selecting a teacher and submitting donation reports.
- An updated navigation link incorporating the campus fund entry and minor database script adjustments.
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| view/next-project/src/pages/campus_fund/index.tsx | Adds the new campus fund page with donation amount calculation and interactive building selection. |
| view/next-project/src/constants/linkItem.tsx | Updates navigation links to include a dedicated campus fund entry. |
| view/next-project/src/components/campus_fund/SelectTeacherModal.tsx | Implements a modal for teacher selection associated with a building. |
| view/next-project/src/components/campus_fund/ReportModal.tsx | Implements a modal for submitting donation reports. |
| view/next-project/src/components/campus_fund/OpenEditModalButton.tsx | Introduces the button component for opening the donation report modal. |
| view/next-project/package.json | Adds react-datepicker dependency for date selection functionality. |
| mysql/db/19_expenses.sql | Comments out the stored procedure code, preserving legacy code for potential future use. |
| mysql/db/19_expenses.sh | Provides a shell script to create/update the stored procedure for expense processing. |
Files not reviewed (1)
- view/next-project/package-lock.json: Language not supported
| cursor="pointer" | ||
| onClick={() => handleBuildingClick(building.name)} |
Copilot
AI
May 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GridItem used for building selection is clickable but lacks keyboard accessibility attributes. Consider adding 'role="button"' and 'tabIndex={0}' to ensure it is accessible via keyboard navigation.
| cursor="pointer" | |
| onClick={() => handleBuildingClick(building.name)} | |
| cursor="pointer" | |
| role="button" | |
| tabIndex={0} | |
| onClick={() => handleBuildingClick(building.name)} | |
| onKeyDown={(e) => { | |
| if (e.key === 'Enter' || e.key === ' ') { | |
| e.preventDefault(); | |
| handleBuildingClick(building.name); | |
| } | |
| }} |
| } | ||
|
|
||
| const OpenEditModalButton = (props: Props) => { | ||
| const [showModal, setShowModal] = useState(false); |
Copilot
AI
May 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The state variable 'showModal' is set but never used in the component; consider removing it or integrating modal toggling logic if it was intended to control visibility.
Deploying finansu with
|
| Latest commit: |
44013f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://70770a7c.finansu.pages.dev |
| Branch Preview URL: | https://feat-sato-887-add-fund-page.finansu.pages.dev |
Chikuwa0141
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正箇所をNotionにまとめたので確認お願いします!
対応Issue
resolve #887
概要
募金ページのデザイン実装
データは仮に定義しているもので、APIのPRがmergeされ次第、変更する
画面スクリーンショット等
URLテスト項目
備考