feat: add job progress logging for cell-by-cell generation #259
+359
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds detailed progress logging during cell-by-cell column generation with thread-safe counters. Reports progress every ~10% with completion percentage, success/failure counts, processing rate, and ETA.
Move progress tracking logic from nested functions with nonlocal variables into a separate, testable ProgressTracker class. This improves code readability and testability while maintaining the same functionality.
The ProgressTracker requires total_records to be an integer for comparison operations.
Add 19 tests covering: - Initialization and configuration - Success and failure recording - Thread safety under concurrent access - Logging behavior at intervals - Edge cases (zero records, small totals)
johnnygreco
reviewed
Jan 29, 2026
...ges/data-designer-engine/src/data_designer/engine/dataset_builders/utils/progress_tracker.py
Outdated
Show resolved
Hide resolved
johnnygreco
requested changes
Jan 29, 2026
Contributor
johnnygreco
left a comment
johnnygreco
left a comment
There was a problem hiding this comment.
Love pulling it out into a class like this! Thanks @eric-tramel!
Just the smallest of small nits
…_builders/utils/progress_tracker.py Co-authored-by: Johnny Greco <jogreco@nvidia.com>
7 tasks
johnnygreco
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ColumnWiseDatasetBuilderProgressTrackerclassExample output
Test plan
ProgressTrackerclass (19 tests covering thread safety, edge cases, logging)