Skip to content

Conversation

@salmanmkc
Copy link
Contributor

Summary

Upgrade GitHub Actions to their latest versions to ensure compatibility with Node 24, as Node 20 will reach end-of-life in April 2026.

Changes

Action Old Version(s) New Version Release Files
actions/checkout v4 v6 Release ci.yml, docs.yml
actions/setup-python v5 v6 Release ci.yml

Context

Per GitHub's announcement, Node 20 is being deprecated and runners will begin using Node 24 by default starting March 4th, 2026.

Why this matters

  • Node 20 EOL: April 2026
  • Node 24 default: March 4th, 2026
  • Action: Update to latest action versions that support Node 24

Security Note

Actions that were previously pinned to commit SHAs remain pinned to SHAs (updated to the latest release SHA) to maintain the security benefits of immutable references.

Testing

These changes only affect CI/CD workflow configurations and should not impact application functionality. The workflows should be tested by running them on a branch before merging.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

📝 Walkthrough

Walkthrough

The pull request updates GitHub Actions versions in workflow files: actions/checkout moved to v6 in CI and docs workflows, and actions/setup-python was bumped in the CI workflow. No workflow logic, control-flow, or public API declarations were changed.

Changes

Cohort / File(s) Summary
GitHub Actions: CI workflow
.github/workflows/ci.yml
Bumped actions/checkout to v6 and upgraded actions/setup-python to a newer major version; no logic or step changes.
GitHub Actions: Docs workflow
.github/workflows/docs.yml
Updated actions/checkout from v4 to v6 in Build job; Build CMS job still uses v4. No other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped through workflows, light and quick,
I nudged checkout to v6 with a flick,
Gave Python a nudge to newer days,
Tiny changes — gentle rabbit praise! 🥕✨

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: upgrading GitHub Actions for Node 24 compatibility, which is the core objective of the PR.
Description check ✅ Passed The description is directly related to the changeset, providing detailed context about the GitHub Actions upgrades (checkout v4→v6, setup-python v5→v6) and the rationale for Node 24 compatibility.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 16, 2025

Greptile Overview

Greptile Summary

This PR updates GitHub Actions workflow dependencies to newer major versions intended to remain compatible with the upcoming Node 24 default on GitHub-hosted runners. In ci.yml, both lint and test jobs bump actions/checkout to v6 and actions/setup-python to v6.

One workflow upgrade is incomplete: docs.yml updates checkout to v6 for the build job, but the build-cms job still uses actions/checkout@v4, which conflicts with the PR’s goal of eliminating Node-20-based actions before the runner transition.

Confidence Score: 4/5

  • Mostly safe to merge, but one workflow job likely breaks under Node 24 runner defaults.
  • Changes are limited to workflow action version bumps and are low blast-radius, but docs.yml leaves build-cms on actions/checkout@v4, which contradicts the Node 24 compatibility motivation and can cause CI failures once Node 20-based actions are deprecated.
  • .github/workflows/docs.yml

Important Files Changed

Filename Overview
.github/workflows/ci.yml Bumps actions/checkout from v4→v6 and actions/setup-python from v5→v6 in lint and test jobs; no functional workflow logic changes.
.github/workflows/docs.yml Updates actions/checkout v4→v6 only for the build job; build-cms still uses actions/checkout@v4, undermining the stated Node 24-compatibility goal.

Sequence Diagram

sequenceDiagram
  autonumber
  participant GH as GitHub Runner
  participant CI as ci.yml workflow
  participant Docs as docs.yml workflow
  participant CO as actions/checkout
  participant PY as actions/setup-python

  GH->>CI: Trigger on pull_request
  CI->>CO: Checkout repository (v6)
  CI->>PY: Setup Python (v6)
  CI->>GH: Run lint/test steps

  GH->>Docs: Trigger on push/tags/workflow_dispatch
  Docs->>CO: Checkout repository (build job: v6)
  Docs->>GH: Build & upload Pages artifact

  Docs->>CO: Checkout repository (build-cms job: v4)
  Docs->>GH: Setup Node 24 & build CMS docs
  Docs->>GH: Upload CMS docs artifact

  Docs->>GH: Deploy GitHub Pages (deploy job)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@salmanmkc salmanmkc force-pushed the upgrade-github-actions-node24 branch from 103aa63 to 9b63481 Compare December 16, 2025 12:11
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@amaslenn amaslenn requested a review from jeffnvidia as a code owner February 10, 2026 14:19
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/docs.yml (1)

39-40: ⚠️ Potential issue | 🟠 Major

Inconsistency: build-cms job still uses actions/checkout@v4.

The build job (Line 20) was upgraded to actions/checkout@v6, but the build-cms job here remains on @v4. If the goal is Node 24 compatibility ahead of Node 20 EOL, this job should be updated as well.

Proposed fix
     - name: Checkout
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6

@amaslenn amaslenn merged commit e01d647 into NVIDIA:main Feb 10, 2026
4 checks passed
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 10, 2026

Additional Comments (1)

.github/workflows/docs.yml
Incomplete checkout upgrade

build-cms still uses actions/checkout@v4 (docs.yml:40) while the rest of the PR upgrades checkout to @v6 for the Node 24 runner transition. This job also sets up Node 24, so leaving checkout on the older major undermines the stated goal and is likely to fail once Node 20-based JS actions are rejected. Update build-cms to the same checkout major/versioning strategy as the other jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants