Skip to content

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Oct 22, 2025

Closes #1177.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Oct 22, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud cpcloud requested review from leofang and mdboom October 22, 2025 20:15
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR removes all Python 3.13t (free-threading) build configurations from the CI test matrix in ci/test-matrix.json. The change eliminates 6 test entries: 2 from Linux pull-request matrix (amd64 and arm64), 2 from Windows pull-request matrix (both amd64 with different LOCAL_CTK settings), and 2 from Windows nightly matrix. Python 3.14t free-threading builds are retained.

The rationale is that Python 3.13t had significant stability issues, particularly non-thread-safe ctypes which cuda-python's cuda_pathfinder package heavily relies on. Since Python 3.14t provides stable free-threading support, the team is skipping 3.13t entirely to avoid maintaining experimental support for an experimental interpreter. This pragmatic approach reduces maintenance burden while preserving free-threading capabilities through the more mature 3.14t implementation.

Potential Issues

None identified. The changes are purely CI configuration updates removing unstable test configurations. JSON formatting is correct and matrix ordering is preserved.

Confidence: 5/5 - This is a straightforward CI configuration change with clear motivation and no code impact.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 22, 2025

Since Python 3.14t provides stable free-threading support

This feels ... overly optimistic 😆

@cpcloud
Copy link
Contributor Author

cpcloud commented Oct 22, 2025

/ok to test

Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

This comment has been minimized.

@cpcloud cpcloud enabled auto-merge (squash) October 22, 2025 21:11
@cpcloud cpcloud merged commit 2a46c40 into NVIDIA:main Oct 22, 2025
64 checks passed
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@cpcloud cpcloud deleted the remove-py313t branch October 23, 2025 00:20
- name: Download cuda.bindings build artifacts from the prior branch
if: ${{ matrix.python-version == '3.13t'
|| matrix.python-version == '3.14'
|| matrix.python-version == '3.14t' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: We don't need 3.14t here? (TBH I don't remember why this if was needed.)

@leofang leofang added this to the cuda-python 13-next, 12-next milestone Oct 23, 2025
@leofang leofang added packaging Anything related to wheels or Conda packages cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module CI/CD CI/CD infrastructure labels Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module packaging Anything related to wheels or Conda packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: remove 3.13t builds

3 participants