-
Notifications
You must be signed in to change notification settings - Fork 236
ci: remove python3.13t builds #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR removes all Python 3.13t (free-threading) build configurations from the CI test matrix in ci/test-matrix.json. The change eliminates 6 test entries: 2 from Linux pull-request matrix (amd64 and arm64), 2 from Windows pull-request matrix (both amd64 with different LOCAL_CTK settings), and 2 from Windows nightly matrix. Python 3.14t free-threading builds are retained.
The rationale is that Python 3.13t had significant stability issues, particularly non-thread-safe ctypes which cuda-python's cuda_pathfinder package heavily relies on. Since Python 3.14t provides stable free-threading support, the team is skipping 3.13t entirely to avoid maintaining experimental support for an experimental interpreter. This pragmatic approach reduces maintenance burden while preserving free-threading capabilities through the more mature 3.14t implementation.
Potential Issues
None identified. The changes are purely CI configuration updates removing unstable test configurations. JSON formatting is correct and matrix ordering is preserved.
Confidence: 5/5 - This is a straightforward CI configuration change with clear motivation and no code impact.
1 file reviewed, no comments
This feels ... overly optimistic 😆 |
|
/ok to test |
mdboom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This comment has been minimized.
This comment has been minimized.
|
| - name: Download cuda.bindings build artifacts from the prior branch | ||
| if: ${{ matrix.python-version == '3.13t' | ||
| || matrix.python-version == '3.14' | ||
| || matrix.python-version == '3.14t' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: We don't need 3.14t here? (TBH I don't remember why this if was needed.)
Closes #1177.