Skip to content

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Nov 19, 2025

Factor out repetitive test_cufile setup code into pytest fixtures.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Nov 19, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 19, 2025

/ok to test

@github-actions

This comment has been minimized.

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice!

@leofang leofang added this to the cuda-python 13-next, 12-next milestone Nov 20, 2025
@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do test Improvements or additions to tests cuda.bindings Everything related to the cuda.bindings module labels Nov 20, 2025
@leofang leofang enabled auto-merge (squash) November 20, 2025 01:39
@leofang
Copy link
Member

leofang commented Nov 20, 2025

LGTM too!

cc @sourabgupta3 @chloechia4 for vis

@leofang leofang merged commit 2cf7971 into NVIDIA:main Nov 20, 2025
112 of 113 checks passed
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@cpcloud cpcloud deleted the factor-cufile-tests branch December 5, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do test Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants