-
Notifications
You must be signed in to change notification settings - Fork 89
CorrDiffCMIP6 integration #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PlotsThe example
|
|
Disclaimer: This is AI-generated, please review response for accuracy Greptile SummaryAdds Key changes:
Implementation notes:
|
| Filename | Overview |
|---|---|
| earth2studio/models/dx/corrdiff.py | Added CorrDiffCMIP6 class (864 lines) with time-dependent preprocessing, CPU streaming, and CMIP6-specific handling |
| examples/20_corrdiff_cmip6.py | Comprehensive example demonstrating CorrDiffCMIP6 usage with CMIP6 datasources and visualization |
| test/models/dx/test_corrdiff.py | Added 269 lines of CorrDiffCMIP6 tests covering preprocessing, sampling, postprocessing, and edge cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
examples/20_corrdiff_cmip6.py, line 62 (link)syntax: calling
load_default_package()will raiseNotImplementedError- the example won't run as written
5 files reviewed, 1 comment


Earth2Studio Pull Request
Summary
CorrDiffCMIP6 integration for CMIP6 downscaling: model wrapper + exports + numbered example + tests
Changes
CorrDiffCMIP6CMIP6-specific wrapper implementation inearth2studio/models/dx/corrdiff.pyCorrDiffCMIP6viaearth2studio/models/dx/__init__.pyexamples/20_corrdiff_cmip6.pytest/models/dx/test_corrdiff.pywith focused CorrDiffCMIP6 coverageNotes / Follow-ups
CorrDiffCMIP6.load_default_package()uses a placeholder URI until the final package URI is configured.Checklist
Dependencies