Ensure max number of SM are allocated by mig-parted#85
Open
JunAr7112 wants to merge 1 commit intoNVIDIA:mainfrom
Open
Ensure max number of SM are allocated by mig-parted#85JunAr7112 wants to merge 1 commit intoNVIDIA:mainfrom
JunAr7112 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
JunAr7112
force-pushed
the
update_sm_loop
branch
from
8973c0c to
b001d5c
Compare
rajathagasthya
left a comment
rajathagasthya
left a comment
There was a problem hiding this comment.
This fix looks like a band-aid, not a comprehensive solution as noted in NVIDIA/mig-parted#158.
pkg/nvlib/device/device.go
Outdated
| } else { | ||
| pInfo := p.GetInfo() | ||
| existingInfo := existing.GetInfo() | ||
| if pInfo.GIProfileID < existingInfo.GIProfileID { |
There was a problem hiding this comment.
Is this correct? This prefers lowest profile IDs while changes are made to iterate from the higher IDs first. Doesn't the higher profile IDs have more SMs?
Author
There was a problem hiding this comment.
I wanted to preserve the lowest profile preference for the devicelib function as it is not directly relevant to the changes needed to ensure max number of SM are allocated per device. This will also ensure that our current mig-parted tests will pass.
Author
There was a problem hiding this comment.
Removed this change. Not necessary
JunAr7112
force-pushed
the
update_sm_loop
branch
from
b001d5c to
89cd69a
Compare
Signed-off-by: Arjun <agadiyar@nvidia.com>
JunAr7112
force-pushed
the
update_sm_loop
branch
from
89cd69a to
340d43e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.