Draft
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change is a minor refactor of the nvml health monitor. It groups similar functionality together so as to make further extensions / changes simpler. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Collaborator
|
Nice draft, LGTM, look forward for when it's reayd for review. |
Contributor
Collaborator
ArangoGutierrez
added a commit
to ArangoGutierrez/k8s-device-plugin
that referenced
this pull request
Jan 12, 2026
…heckHealth - Add withDevicePlacements wrapper struct for testable device placement - Add TestCheckHealth test using dgxa100 mock server - Update checkHealth to use the wrapper pattern - Vendor go-nvml mock packages including dgxa100 Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
ArangoGutierrez
added a commit
to ArangoGutierrez/k8s-device-plugin
that referenced
this pull request
Jan 12, 2026
…heckHealth - Add withDevicePlacements wrapper struct for testable device placement - Add TestCheckHealth test using dgxa100 mock server - Update checkHealth to use the wrapper pattern - Vendor go-nvml mock packages including dgxa100 Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before starting a more serious refactor as in #1508 it may be useful to:
This is a demonstrator, and would still need to have additional work done to get this to the same point where #1508 is. The idea being that we get there more gradually, with fewer unrelated changes.