Skip to content

Fix healthchecking on old devices#1562

Merged
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:fix-conditional
Jan 22, 2026
Merged

Fix healthchecking on old devices#1562
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:fix-conditional

Conversation

@elezar
Copy link
Member

@elezar elezar commented Dec 10, 2025

In cases where registering events for a device are not supported, we should not mark the device as unhealthy, but skip the device instead.

@elezar elezar marked this pull request as ready for review December 10, 2025 13:07
In cases where registering events for a device are not supported,
we should not mark the device as unhealthy, but skip the device instead.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 12, 2026

/ok to test

@ArangoGutierrez, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@ArangoGutierrez
Copy link
Collaborator

/ok-to-test 8cd1447

@elezar
Copy link
Member Author

elezar commented Jan 12, 2026

/cherry-pick release-0.18

@elezar elezar merged commit 3385c13 into NVIDIA:main Jan 22, 2026
11 checks passed
@elezar elezar deleted the fix-conditional branch January 22, 2026 11:59
@github-actions
Copy link

🤖 Backport PR created for release-0.18: #1594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants