Remove helm value for gpuResourcesEnabledOverride#463
Draft
klueska wants to merge 6 commits intoNVIDIA:mainfrom
Draft
Remove helm value for gpuResourcesEnabledOverride#463klueska wants to merge 6 commits intoNVIDIA:mainfrom
klueska wants to merge 6 commits intoNVIDIA:mainfrom
Conversation
github-project-automation
bot
moved this to Backlog
in Planning Board: k8s-dra-driver-gpu
klueska
force-pushed
the
remove-gpuResourcesEnabledOverride
branch
from
aa5a432 to
155186d
Compare
This is a straight copy of this PR kubernetes-sigs/dra-example-driver#75, with minimal changes to make it work in this repo. Signed-off-by: Kevin Klues <kklues@nvidia.com>
Signed-off-by: Kevin Klues <kklues@nvidia.com>
Signed-off-by: Kevin Klues <kklues@nvidia.com>
Signed-off-by: Kevin Klues <kklues@nvidia.com>
Previously, the webhook only supported cert-manager with a self-signed issuer for TLS certificate generation and management. With this patch, users can now provide their own TLS certificates via secret mode or use custom cert-manager issuers (issuer/clusterissuer) with specified issuer names. Signed-off-by: Kevin Klues <kklues@nvidia.com>
With this removed, the GPU side of the driver will be enabled by default with no safeguards to ensure that someone explicity sets it to false if that is their actual intention. Signed-off-by: Kevin Klues <kklues@nvidia.com>
klueska
force-pushed
the
remove-gpuResourcesEnabledOverride
branch
from
155186d to
8df56a8
Compare
Collaborator
Collaborator
|
We still need a patch like this for the 25.12.0 release -- correct? (With the 25.12.0 release, we don't want people to have to set CC @shivamerla |
Collaborator
Author
|
No! We still don't want this on by default until the DRA extended resources API is GA in upstream Kubernetes. The change relevant to this release was to change the error message. It was merged here: #809 |
Collaborator
|
Got it. I missed #809 -- the new error message is clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this removed, the GPU side of the driver will be enabled by default with no safeguards to ensure that someone explicity sets it to false if that is their actual intention.