api: recognize Fabric GPU sharing strategy in validation#849
Open
AkshatDudeja77 wants to merge 1 commit intoNVIDIA:mainfrom
Open
api: recognize Fabric GPU sharing strategy in validation#849AkshatDudeja77 wants to merge 1 commit intoNVIDIA:mainfrom
AkshatDudeja77 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Akshat Dudeja <akshat.dudeja77@gmail.com>
github-project-automation
bot
moved this to Backlog
in Planning Board: k8s-dra-driver-gpu
klueska
reviewed
Feb 8, 2026
Comment on lines
+47
to
+49
| if s == FabricStrategy { | ||
| return fmt.Errorf("fabric GPU sharing strategy is not enabled") | ||
| } |
Collaborator
There was a problem hiding this comment.
I still don't undertand how this qualifies is a "Sharing Strategy".
Also, I don't thin this needs to be in a PR on its own, I'd rather see it as a separate commit in the same PR that introduces the constant.
Author
There was a problem hiding this comment.
Understood, that’s fair.
This PR was intended as a follow-up to avoid validation rejecting a future Fabric-backed configuration, but given that Fabric doesn’t clearly qualify as a SharingStrategy in the same sense as MPS or TimeSlicing, I agree this isn’t the right place for it.
I’m happy to close this PR and treat any Fabric-related validation changes as part of a single PR once there’s a concrete implementation and a clearer API shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Why this is needed
Fabric-attached GPUs (IMEX / NVLink fabric) introduce sharing modes that are not purely local.
Without this change, valid Fabric configurations are rejected during validation.
This PR is intentionally minimal and scoped to validation only.
Scope