build: Fix pin of opentelemetry-api and update lock file#16
build: Fix pin of opentelemetry-api and update lock file#16ko3n1g wants to merge 6 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
This will restrict The current Exact versions for our own testing are already locked by |
Hey yeah, sorry, didn't have time to continue this. Originally I thought I had seen a breakage on opentelemetry 1.35, but that one was a fluke. But I think this PR is still relevant to some extend, since upgrading the lock-file shouldn't break the CI. I think this might give evidence that some recent upstream dependencies aren't compatible with msc anymore. |
|
I'm not too sure why that's failing. It doesn't seem like an issue with an upgraded dependency. We can test the PR by mirroring internally to a GitLab MR to test using our CI there (long-term plan is to move development to GitHub). Though I'd be surprised if the result changed since we're using Nix shells everywhere. |
|
Anyways the exact changes for this PR probably aren't needed, but we need to change any We'll create an MR for this on GitLab directly. |
Yeah, I wasn't sure about your preference:) If pinning majors works for you, that's great. Pinning minors seems safer but also improses more limitations on users. In any case, I'd strongly recommend to have a weekly uv-lock-upgrade job in place that verifies that you're still compatible against the upper boundaries (however they are defined) |
|
We've actually made uv intentionally resolve the lowest allowed versions of direct dependencies to make sure the lower end of our version ranges work. multi-storage-client/pyproject.toml Line 196 in aa8e09e Ideally this works fine, but it's possible for upstream dependencies to break semver. |
|
Followup GitLab MR opened. Closing this PR. |
Summary
Add a one line overview of what this PR aims to accomplish.
Details
Describe your changes. You can be more detailed and descriptive here.
Usage
You can potentially add a usage example below.
# Add a code snippet demonstrating how to use this.Before your PR is "Ready for review"
.release_notes/.unreleased.md?Additional Information