Fix sharedDevMems cuMem import cleanup to prevent proxy-side device memory leaks #1968
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes proxy-side cleanup for sharedDevMems imported via cuMem to prevent GPU memory leaks across communicator lifetimes. The import path does not early-release handles, so teardown must perform proper unmap/addressFree and handle release.
Related Issues
N/A
Changes & Impact
ncclCommAbort()when the communicator is using the NET transport/path (abort may bypass the normal finalize path, but proxy resources still need correct teardown).Performance Impact
Not measured; no expected runtime impact beyond cleanup on teardown.
Testing: Not run (not requested).