Skip to content

Comments

Remove padding for page elements#1376

Open
edknv wants to merge 2 commits intoNVIDIA:mainfrom
edknv:edwardk/remove-yolox-scaling-padding
Open

Remove padding for page elements#1376
edknv wants to merge 2 commits intoNVIDIA:mainfrom
edknv:edwardk/remove-yolox-scaling-padding

Conversation

@edknv
Copy link
Collaborator

@edknv edknv commented Feb 4, 2026

Description

This PR removes padding from page element preprocessing. The padding_tuple parameter was originally required when the gRPC interface expected raw numpy arrays with uniform dimensions for batching. The interface has since moved to base64-encoded images, which handle variable-sized inputs natively.

bo767 on A100
throughput: 22.9 pages/sec -> 23.9 pages/sec
recall@5: 0.846 -> 0.847

earnings on A100
throughput: 25.6 pages/sec -> 26.3 pages/sec
recall@5: 0.628 -> 0.633

earnings on RTX A6000
throughput: 15.1 pages/sec -> 15.5 pages/sec

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • If adjusting docker-compose.yaml environment variables have you ensured those are mimicked in the Helm values.yaml file.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 4, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@edknv edknv force-pushed the edwardk/remove-yolox-scaling-padding branch from 053b5b1 to 26d470c Compare February 5, 2026 20:53
@edknv edknv requested a review from jioffe502 February 19, 2026 05:48
@edknv edknv marked this pull request as ready for review February 19, 2026 05:48
@edknv edknv requested a review from a team as a code owner February 19, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant