[release-1.18] Allow nvcdi feature flags to be set for the jit-cdi mode#1443
Merged
elezar merged 2 commits intorelease-1.18from Nov 10, 2025
Merged
[release-1.18] Allow nvcdi feature flags to be set for the jit-cdi mode#1443elezar merged 2 commits intorelease-1.18from
jit-cdi mode#1443elezar merged 2 commits intorelease-1.18from
Conversation
This change allows users the posibility to explicitly specify feature flags for using the `jit-cdi` mode. This allows, for example, for users to opt-in to use nvsandboxutils in the default mode in addition to when generating CDI specs explicitly. Signed-off-by: Evan Lezar <elezar@nvidia.com> (cherry picked from commit ffe768b)
This original implementation of the FeatureDisableNvsandboxUtils feature flag included a dash that was not supposed to be there. This change updates the feature flag's string representation to disable-nvsandboxutils. Special handling is included for users that may still use the old string value (e.g. for the nvidia-ctk cdi generate command), but no changes are expected for users of the nvcdi API. Signed-off-by: Evan Lezar <elezar@nvidia.com> (cherry picked from commit a37bab4)
elezar
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated backport of #1419 to
release-1.18✅ Cherry-pick completed successfully with no conflicts.
Original PR: #1419
Original Author: @elezar
Cherry-picked commits (2):
ffe768bAllow nvcdi FeatureFlags to be configured for jit-cdi modea37bab4Correct typo in nvsandboxutils feature flagThis backport was automatically created by the backport bot.