Skip to content

chore: Fix release tooling to support annotated tags#1669

Merged
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:fix-release-of-annotated-tags
Feb 23, 2026
Merged

chore: Fix release tooling to support annotated tags#1669
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:fix-release-of-annotated-tags

Conversation

@elezar
Copy link
Member

@elezar elezar commented Feb 20, 2026

Annotated tags are git objects themselves and we should therefore get the git reference from their commit and not the tag itself.

For example:

$ git log
commit c57370920f32c0d78af2de5cc89a67f06da32134 (HEAD -> main, tag: v1.19.0-rc.4, upstream/main, upstream/HEAD)
$  git rev-parse v1.19.0-rc.4
86606c7758ae01f58777317eca89afd8135dffdb
$ git rev-parse v1.19.0-rc.4^{commit}
c57370920f32c0d78af2de5cc89a67f06da32134

which is the same SHA as main.

Annotated tags are git objects themselves and we should therefore
get the git reference from their commit and not the tag itself.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
Copy link
Member Author

elezar commented Feb 20, 2026

/cherry-pick release-1.18

@elezar elezar merged commit 0472d5f into NVIDIA:main Feb 23, 2026
16 checks passed
@elezar elezar deleted the fix-release-of-annotated-tags branch February 23, 2026 16:10
@github-actions
Copy link

🤖 Backport PR created for release-1.18: #1673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants