chore: Rename isIntegratedGPUID function to isOrinGPUID#1674
Open
elezar wants to merge 2 commits intoNVIDIA:mainfrom
Open
chore: Rename isIntegratedGPUID function to isOrinGPUID#1674elezar wants to merge 2 commits intoNVIDIA:mainfrom
elezar wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Pull Request Test Coverage Report for Build 22315219649Details
💛 - Coveralls |
cdesiniotis
approved these changes
Feb 23, 2026
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
improve-lib-csv-readability
branch
from
685d2df to
4f7a404
Compare
elezar
changed the title
cdesiniotis
reviewed
Feb 25, 2026
| // We explicitly handle this case. | ||
| if pciInfo.Domain == 0 && pciInfo.Bus == 1 && pciInfo.Device == 0 { | ||
| return true, nil | ||
| } |
Contributor
There was a problem hiding this comment.
Did you mean to delete the lines that immediately proceed this?
Member
Author
There was a problem hiding this comment.
Sorry. Trying to do too many things.
cdesiniotis
requested changes
Feb 25, 2026
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
improve-lib-csv-readability
branch
from
4f7a404 to
63a2e81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1461 (comment)