fix: skip config.json download counter when HF_HUB_OFFLINE is set#62
Open
haosenwang1018 wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix: skip config.json download counter when HF_HUB_OFFLINE is set#62haosenwang1018 wants to merge 1 commit intoNVIDIA:mainfrom
haosenwang1018 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The hf_hub_download call for config.json (used only to increment the download counter) fails when HF_HUB_OFFLINE=1. Guard the call with an environment variable check. Fixes NVIDIA#54 Signed-off-by: haosenwang1018 <haosenwang1018@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Line 429 in
server.pycallshf_hub_download(args.hf_repo, "config.json")unconditionally to increment the download counter. WhenHF_HUB_OFFLINE=1is set, this fails because the HuggingFace Hub client cannot reach the server.Fix
Guard the download counter call with
os.environ.get("HF_HUB_OFFLINE"). The call is only used for analytics and is not required for the server to function.Fixes #54