fix: remove torch upper bound to support Python 3.13#63
Open
haosenwang1018 wants to merge 2 commits intoNVIDIA:mainfrom
Open
fix: remove torch upper bound to support Python 3.13#63haosenwang1018 wants to merge 2 commits intoNVIDIA:mainfrom
haosenwang1018 wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
The hf_hub_download call for config.json (used only to increment the download counter) fails when HF_HUB_OFFLINE=1. Guard the call with an environment variable check. Fixes NVIDIA#54 Signed-off-by: haosenwang1018 <haosenwang1018@users.noreply.github.com>
torch < 2.5 only has wheels for Python 3.10-3.12. Python 3.13 users cannot install the package. Remove the upper bound since torch >= 2.5 maintains backward compatibility. Fixes NVIDIA#22 Signed-off-by: haosenwang1018 <haosenwang1018@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pyproject.tomlspecifiestorch >= 2.2.0, < 2.5, but torch versions before 2.5 only have wheels for Python 3.10-3.12. Python 3.13 users cannot install the package.Fix
Remove the
< 2.5upper bound. PyTorch maintains backward compatibility within major versions, and torch >= 2.5 adds Python 3.13 support.Fixes #22