feat: v1 finished by NaBuchholz · Pull Request #84 · NaBuchholz/ft_minishell

NaBuchholz · 2025-07-13T18:14:17Z

No description provided.

Sync main

* fix: Update Makefile echo commands for consistency and readability * fix: Update main function to include readline and history management

) * fix: Add /build to .gitignore to exclude build directory from version control * fix: Update Makefile to improve build process and add dependency tracking * fix: Update Makefile header and adjust header file inclusion order * fix: Update minishell.h to remove token structures and adjust shell struct * feat: Add lexer.h header file with token type and structure definitions * feat: Implement input processing and readline loop in main shell function

* feat: add test utilities for token debugging and assertions * feat: implement token creation functions and add corresponding tests * fix: improve token memory management and add tests for token creation * feat: add token creation tests for various scenarios * feat: add test target to Makefile for running unit tests * feat: add ft_isspace function to check for whitespace characters * doc: add doc to free_token * feat: implement functions for skipping whitespace and determining operator types * feat: add token handling functions and improve token list debugging * fix: norm errors * feat: add tokenizer and lexer test functions, including free_token_list * feat: add memory tests for token management functions * fix: typo * fix: update token free check and header comment timestamp * fix: update function name for whitespace check in ft_atoi * fix: remove semicolon from include directive in test_utils.h * fix: add test_runner to .gitignore * fix: update Makefile for test integration and improve debug output * fix: norm in init.c and lexer.c --------- Co-authored-by: Nathalia Vitoria Buchholz <nbuchhol@c1r5p3.42sp.org.br>

* fix: update Makefile for Valgrind suppression and add readline suppression file * feat: add test targets for running tests and Valgrind checks in Makefile * test: main function to include new test functionality * feat: enhance lexer with word handling and metacharacter checks * fix: correct parameter descriptions in skip_whitespace function documentation --------- Co-authored-by: Nathalia Vitoria Buchholz <nbuchhol@c1r5p3.42sp.org.br>

…#65) * fix: update Makefile to include additional test source files * feat: add support for redirection append operator in lexer * feat: add tests for append operator functionality in lexer

* fix: update lexer.h to include TOKEN_HEREDOC in token type enumeration * feat: implement operator type recognition in new operators.c file * feat: add is_operator function to identify shell operator metacharacters

* refactor: remove memory leak test from memory tests suite * feat: add heredoc support in lexer and token utilities * test: add heredoc tests and update test runner * fix: norm in test heredoc --------- Co-authored-by: Nathalia Vitoria Buchholz <nbuchhol@c1r5p3.42sp.org.br>

* Remove unused parser files: ast.c and expansion.c * Add parser structures and initial command parsing implementation * feat: parser header and Makefile to include new command structures and source files * feat: implement command and redirection management functions * fix: correct struct name for command * feat: add command counting and printing functions for debugging * feat: add get_next_token function to retrieve the next token in the list * feat: implement validation and identification functions for redirection tokens * feat: add validation and utility functions for command and redirection handling * feat: add syntax validation functions for token sequences * wip * fix: remove outdated comment * wip: parse cmds * feat: implement redirection parsing and update command structure * fix: correct function name for redirection checks in syntax validation * feat: enhance command and redirection structures with additional documentation * feat: add syntax validation tests for command parsing and redirection * test: update heredoc tests and add simple command parsing tests * fix: correct function name in token cleanup calls for append operator tests * test: add heredoc test function and update cleanup calls for token validation * test: add parser tests and update Makefile and test utilities * feat: add syntax validation function for token list * Merge branch 'dev' into NaBuchholz/issue12 * fix: norm in syntax check and test files * refactor: rename quote processing functions for norm check

* refactor: Update argument structure to include quote type and modify command arguments * feat: Add argument and redirection utility functions * refactor: Update argument handling and add debugging utilities * refactor: Simplify command creation by removing argument count parameter --------- Co-authored-by: Nathalia Vitoria Buchholz <nbuchhol@c1r5p3.42sp.org.br>

* test: Add redirection tests for output, input, append, and multiple redirects * refactor: Update redirection parsing functions and add test for redirections * feat: Add debugging functions for command and redirection lists * feat: Add debugging for command parsing and update file headers * fix: norm

…ocess.c | modified parser.h

) * feat: Implement pipeline parsing in parser and update related functions * fix: norm * feat: Add executor header and utility functions for command execution * feat: Update Makefile and minishell.h, add syntax and command error handling functions * feat: Refactor syntax validation and implement command execution in executor * feat: Add token_type_to_symbol function for better error reporting in syntax validation * Merge branch 'dev' into NaBuchholz/issue19

…ore to exclude .vscode directory

* test: Add pipeline parsing tests and update related files * feat: Implement pipeline execution and related utilities * fix: apply the norm closes #35 closes #36

* feat: Implement signal handling and environment initialization in shell loop * fix: Norm

* WIP: Implement heredoc functionality in the shell * feat: Add heredoc signal handling and related tests * fix: Improve exit command detection in utils and update file headers

* fix: remove bypass exit to built in exit cmd * refactor: remove unused cleanup and history source files * refactor: remove unused functions * fix: add 'cd' command handling in builtins dispatcher

…tion

Copilot

Pull Request Overview

This PR completes the first version of the minishell by adding error-reporting utilities, comprehensive testing, and refining core components.

Introduce syntax_error and command_error functions in utils.c for uniform error messages.
Add an extensive test suite covering tokenization, lexing, parsing, redirections, heredoc, environment management, and memory handling.
Update signal handling, main loop, and pipeline execution, but a debug print remains in production code.

Reviewed Changes

Copilot reviewed 98 out of 103 changed files in this pull request and generated 3 comments.

File	Description
src/utils.c	Added `syntax_error` and `command_error` functions
src/tests/	Added dozens of new test files for tokens, lexer, parser, heredoc, environment, and memory
src/executor/pipeline_utils.c	Leftover debug `printf` in `create_pipes`
src/parser/syntax_check.c	Production code includes `test_utils.h` unnecessarily

Comments suppressed due to low confidence (2)

src/tests/test_token_utils.c:27

[nitpick] The function returns "TOKEN_HEREDOC" while other token names omit the TOKEN_ prefix (e.g., "WORD"). Consider returning a consistent string like "HEREDOC."

	else if (type == TOKEN_HEREDOC)

src/parser/syntax_check.c:14

The production parser code includes test_utils.h, which is only needed for tests. Remove this unnecessary include.

#include "test_utils.h"

Copilot · 2025-07-13T18:15:45Z

src/executor/pipeline_utils.c

+		}
+		printf("🔧 PIPE: Criado pipe[%d] = {%d, %d}\n",
+			i, (*pipes)[i * 2], (*pipes)[i * 2 + 1]);


This debug printf outputs Portuguese text and emojis in production code. Consider removing it or guarding it under a debug flag.

Suggested change

}

printf("🔧 PIPE: Criado pipe[%d] = {%d, %d}\n",

i, (*pipes)[i * 2], (*pipes)[i * 2 + 1]);

}

#ifdef DEBUG

printf("🔧 PIPE: Criado pipe[%d] = {%d, %d}\n",

i, (*pipes)[i * 2], (*pipes)[i * 2 + 1]);

#endif

Copilot · 2025-07-13T18:15:45Z

src/tests/test_token_type_append.c

+	tokens = tokenize_input(">>");
+	debug_token_list(tokens);
+	if (!tokens || tokens->type != TOKEN_REDIR_APPEND)
+		return (cleanup_and_return(tokens, "ExpecTOKEN_REDIR_APPEND", 1, NULL));


The error message has a typo and missing space: "ExpecTOKEN_REDIR_APPEND" should be "Expect TOKEN_REDIR_APPEND".

Suggested change

return (cleanup_and_return(tokens, "ExpecTOKEN_REDIR_APPEND", 1, NULL));

return (cleanup_and_return(tokens, "Expect TOKEN_REDIR_APPEND", 1, NULL));

Copilot · 2025-07-13T18:15:45Z

src/tests/test_token_utils.c

+	if (expected && token->value
+		&& ft_strncmp(token->value, expected, ft_strlen(expected)) != 0)
+	{
+		printf("❌ ASSERT FAIL:Expec '%s', got '%s'\n", expected, token->value);


Missing space after colon and typo: "ASSERT FAIL:Expec" should be "ASSERT FAIL: Expect".

Suggested change

printf("❌ ASSERT FAIL:Expec '%s', got '%s'\n", expected, token->value);

printf("❌ ASSERT FAIL: Expect '%s', got '%s'\n", expected, token->value);

NaBuchholz and others added 30 commits May 30, 2025 21:14

Merge pull request #59 from NaBuchholz/main

7acf3c7

Sync main

Improve Makefile output and enhance main with readline

59b02e0

* fix: Update Makefile echo commands for consistency and readability * fix: Update main function to include readline and history management

Definir estruturas principais (#61)

28cbbb6

Add support for redirection append operator in lexer and tests (Fixes…

b6c6e0c

…#65) * fix: update Makefile to include additional test source files * feat: add support for redirection append operator in lexer * feat: add tests for append operator functionality in lexer

Add operator type recognition and update token enumeration (#66)

34e2c8a

* fix: update lexer.h to include TOKEN_HEREDOC in token type enumeration * feat: implement operator type recognition in new operators.c file * feat: add is_operator function to identify shell operator metacharacters

make sync in my local pc

c8cef39

add quote function

de68ee4

completing the function

afd7603

make single quote function

aaf3cfc

add double quotes in quotes.c

69f06bc

begin expansion.c

27a38e8

change in any files

5b9880a

make expasion

60fffb5

make expasion

59b6f61

feat: Add handling for single and double quotes in lexer (#71)

9693eed

update with dev

e4765d6

Merge branch 'dev' into vini

e412b9c

make expansion, add expansion_utils, add token_expansion

279e142

make expansion, add expansion_basic.c, expansion_main.c, expansion_pr…

af6b90e

…ocess.c | modified parser.h

modified parser.h

0caaf77

modified minishell.h, parser.h, add exit_status.c

f8516b2

merging from dev

28711a7

Vinicius Da Silva Lima and others added 23 commits July 6, 2025 17:35

Merge branch 'dev' into vini

b7b84e1

fix errors

3248dcb

fixing errors

e21035b

compiler errors fixed

24822a2

doc: Remove Visual Studio Code configuration files and update .gitign…

fa584e0

…ore to exclude .vscode directory

Implement pipeline execution and testing utilities (#78) close

7498c14

* test: Add pipeline parsing tests and update related files * feat: Implement pipeline execution and related utilities * fix: apply the norm closes #35 closes #36

fixed builtins_dispatcher.c

23aa148

fixed norminette

cad1a26

feat: Implement signal handling (#79)

84fc3dd

* feat: Implement signal handling and environment initialization in shell loop * fix: Norm

fix: Update signal handling and remove unused SIGQUIT handler

6f40bff

feat: Implement heredoc functionality (#80)

297ec24

* WIP: Implement heredoc functionality in the shell * feat: Add heredoc signal handling and related tests * fix: Improve exit command detection in utils and update file headers

maked built-in cd

d275c0a

fix: Update signal handling to include SIGQUIT handler (#81)

fa067d9

Merge branch 'dev' into vini

365b3d9

created implematation built-in exit

4879237

made built-in exit

a80558e

done built-in pwd

c066f75

feat: Implement main loop with readline and history support (#82)

0ae2537

done built-in echo

8e070a4

Merge branch 'dev' into vini

326421c

implementation integration of built-ins

583c7ec

Fix exit command handling and clean up unused code (#83)

7883f29

* fix: remove bypass exit to built in exit cmd * refactor: remove unused cleanup and history source files * refactor: remove unused functions * fix: add 'cd' command handling in builtins dispatcher

refactor: Update README to reflect project name and enhance documenta…

cc150a0

…tion

NaBuchholz added this to the Entrega milestone Jul 13, 2025

NaBuchholz self-assigned this Jul 13, 2025

Copilot AI review requested due to automatic review settings July 13, 2025 18:14

NaBuchholz added this to VammmmmBoraaa! Jul 13, 2025

NaBuchholz merged commit c441322 into main Jul 13, 2025
2 checks passed

github-project-automation bot moved this to Done in VammmmmBoraaa! Jul 13, 2025

Copilot AI reviewed Jul 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: v1 finished#84

feat: v1 finished#84
NaBuchholz merged 77 commits intomainfrom
dev

NaBuchholz commented Jul 13, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 13, 2025

Uh oh!

Copilot AI Jul 13, 2025

Uh oh!

Copilot AI Jul 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	return (cleanup_and_return(tokens, "ExpecTOKEN_REDIR_APPEND", 1, NULL));
	return (cleanup_and_return(tokens, "Expect TOKEN_REDIR_APPEND", 1, NULL));

	printf("❌ ASSERT FAIL:Expec '%s', got '%s'\n", expected, token->value);
	printf("❌ ASSERT FAIL: Expect '%s', got '%s'\n", expected, token->value);

Conversation

NaBuchholz commented Jul 13, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants