Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe update mechanism in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@updater/src/main.js`:
- Around line 609-615: The checksum comparison in the block using actualChecksum
and expectedChecksum only normalizes base64, but verifyPatchedArtifact can
supply checksums as base64 or hex, so change the comparison to accept both
encodings: compute the chunk SHA-256 in both base64 (no padding) and hex forms
(lowercase), normalize expectedChecksum by trimming padding and casing, detect
if expectedChecksum is hex (matches /^[0-9a-f]{64}$/i) or base64, or simply
compare against both computed forms, and only treat as a miss if neither match;
update references in this block (actualChecksum, expectedChecksum, createHash)
and ensure the writeSync path remains for successful matches.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit
Release Notes