Conversation
…bse; Remove views in the db schema, can bring back in later if needed; Make many functions internal and don't export
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 84.10% 85.11% +1.01%
==========================================
Files 42 46 +4
Lines 2001 2278 +277
==========================================
+ Hits 1683 1939 +256
- Misses 318 339 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new PRASReport.jl package to the PRAS ecosystem that generates interactive HTML reports for power system resource adequacy analysis results. The package extracts "events" (periods of energy shortfall above a threshold) from PRAS simulation results and creates visualizations using embedded databases and web technologies.
Key changes:
- Implements event extraction and analysis from PRAS
ShortfallResultobjects - Creates interactive HTML reports with charts and tabular views using DuckDB WASM
- Provides multiple input methods (results, system models, or file paths)
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| PRASReport.jl/src/ | Core package implementation with event extraction, database operations, and HTML report generation |
| PRASReport.jl/test/ | Test suite covering event extraction and report generation workflows |
| PRASReport.jl/examples/ | Example usage script |
| PRASCore.jl/src/Results/ | Extension to support new NEUE calculations needed by reporting |
| .github/workflows/ | CI configuration for the new package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| regions::Vector{String} | ||
| ) where {N,L,T,E} | ||
|
|
||
| length(lole) != length(eue) != length(neue) != length(regions) && |
There was a problem hiding this comment.
This chained inequality comparison doesn't work as intended in Julia. It should be length(lole) != length(eue) || length(eue) != length(neue) || length(neue) != length(regions) to check that all vectors have equal length.
| length(lole) != length(eue) != length(neue) != length(regions) && | |
| (length(lole) != length(eue) || length(eue) != length(neue) || length(neue) != length(regions)) && |
No description provided.