Skip to content

Return zero NEUE when a region's demand is zero #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GordStephen merged 2 commits into from
Nov 4, 2025
Merged

Return zero NEUE when a region's demand is zero #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df5c13
Return zero NEUE when a region's demand is zero
GordStephen Nov 4, 2025
e2182b5
Increment PRASCore version to v0.8.1
GordStephen Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PRASCore.jl/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ authors = [
"Srihari Sundar <Hari.Sundar@nrel.gov>",
"Julian Florez <Julian.Florez@nrel.gov"
]
version = "0.8.0"
version = "0.8.1"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
25 changes: 23 additions & 2 deletions PRASCore.jl/src/Results/Shortfall.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,33 @@ EUE(x::ShortfallResult{N,L,T,E}, r::AbstractString, t::ZonedDateTime) where {N,L
EUE{1,L,T,E}(MeanEstimate(x[r, t]..., x.nsamples))

function NEUE(x::ShortfallResult)
return NEUE(div(MeanEstimate(x[]..., x.nsamples),(sum(x.regions.load)/1e6)))

demand = sum(x.regions.load)

estimate = if demand > 0
div(MeanEstimate(x[]..., x.nsamples), demand/1e6)
else
MeanEstimate(0.)
end

return NEUE(estimate)

end

function NEUE(x::ShortfallResult, r::AbstractString)

i_r = findfirstunique(x.regions.names, r)
return NEUE(div(MeanEstimate(x[r]..., x.nsamples),(sum(x.regions.load[i_r,:])/1e6)))

demand = sum(x.regions.load[i_r, :])

estimate = if demand > 0
div(MeanEstimate(x[r]..., x.nsamples), demand/1e6)
else
MeanEstimate(0.)
end

return NEUE(estimate)

end

function finalize(
Expand Down
29 changes: 25 additions & 4 deletions PRASCore.jl/src/Results/ShortfallSamples.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,34 @@ EUE(x::ShortfallSamplesResult{N,L,T,P,E}, t::ZonedDateTime) where {N,L,T,P,E} =
EUE(x::ShortfallSamplesResult{N,L,T,P,E}, r::AbstractString, t::ZonedDateTime) where {N,L,T,P,E} =
EUE{1,L,T,E}(MeanEstimate(x[r, t]))

function NEUE(x::ShortfallSamplesResult{N,L,T,P,E}) where {N,L,T,P,E}
return NEUE(div(MeanEstimate(x[]),(sum(x.regions.load)/1e6)))
function NEUE(x::ShortfallSamplesResult)

demand = sum(x.regions.load)

estimate = if demand > 0
div(MeanEstimate(x[]), demand/1e6)
else
MeanEstimate(0.)
end

return NEUE(estimate)

end

function NEUE(x::ShortfallSamplesResult{N,L,T,P,E}, r::AbstractString) where {N,L,T,P,E}
function NEUE(x::ShortfallSamplesResult, r::AbstractString)

i_r = findfirstunique(x.regions.names, r)
return NEUE(div(MeanEstimate(x[r]),(sum(x.regions.load[i_r,:])/1e6)))

demand = sum(x.regions.load[i_r, :])

estimate = if demand > 0
div(MeanEstimate(x[r]), demand/1e6)
else
MeanEstimate(0.)
end

return NEUE(estimate)

end

function finalize(
Expand Down
Loading