Gridlabd datamodel with common DiTTo reader#349
Gridlabd datamodel with common DiTTo reader#349daniel-thom wants to merge 2 commits intoNatLabRockies:kd/gridlabd-datamodelfrom
Conversation
|
|
||
| import enum | ||
|
|
||
| class SimulationEngine(enum.Enum): |
There was a problem hiding this comment.
This may not be required.
| """ | ||
|
|
||
| @abc.abstractmethod | ||
| def read_dataset(self, path, model, **kwargs): |
There was a problem hiding this comment.
Suggestions on better terminology are welcome.
|
My understanding of this proposal is that we are
@daniel-thom feel free to correct me if I'm misinterpreting or omitting certain pieces. |
|
From talking with Dheepak I don't think it will be practical to remove storage of the This still could be bad for two reasons:
Just as a comment, I think the code would be easier to reason about if the |
This integrates the datamodel that Dheepak created with a proposal for a new common reader.
The main new concept here is this:
ditto.readers.reader.DiTToReaderis responsible for controlling the parsing process.DiTToReadercreates a reader interface for the simulation engine specified by the inputs.ditto.readers.reader_interface.ReaderInterfacespecifies the required methods for a reader.I think this design would be better if the
Storeobject was not stored within each DiTTo model instance. I'm OK with keeping it like this.