Opendss writer: add unbalanced loads#408
Opendss writer: add unbalanced loads#408nlaws-camus wants to merge 8 commits intoNatLabRockies:masterfrom
Conversation
|
@tarekelgindy review this after #401 is merged (o.w. unnecessary changes show up in this PR) |
…ditto into opendss-unbal-loads
|
|
||
| # positions (Not mapped) | ||
|
|
||
| for phase_load in i.phase_loads: |
There was a problem hiding this comment.
Hmmm isn't the section below potentially duplicating the changes made above to txt? Should the section below be removed?
There was a problem hiding this comment.
This section already existed and it only applies to ZIP load models. It has been awhile but I think I just left this here because I was not sure where it should go. I have not used the ZIP model in OpenDSS. Are you familiar with how we should parse it for unbalanced loads? Maybe the if can be part of the for phase_load in i.phase_loads above on line 1967
| txt += " kvar={Q}".format(Q=kvars[n]) | ||
|
|
||
| txt += vmin_txt | ||
| txt += vmax_txt |
There was a problem hiding this comment.
See comment above. I think some aspects of the original mapping might not be included here. Is that intentional?
I think that this could be restructured to include duplication with the balanced section.
currently the opendss writer sums up all phase loads to place them on a bus (which implies that loads are balanced equally on each phase at each bus):
https://github.com/NREL/ditto/blob/8d0d7a5ddf71532d6d716b617dc57f84d810d7ea/ditto/writers/opendss/write.py#L1887-L1890
this PR allows for defining individual phase loads by creating
New Loadfor eachPhaseLoad.