Multi yoy integration - combines PRs #456, #460 and #464 at once.#470
Multi yoy integration - combines PRs #456, #460 and #464 at once.#470cdeline wants to merge 93 commits intodevelopmentfrom
Conversation
…nd 'center' labeling options.
…to 459_YoY_label
…mestamp_old_Pandas
…right. Consistent with #394 - multi_yoy
…value = None to avoid breaking pytests.
rdtools/degradation.py
Outdated
| if label not in {None, "right", "left", "center"}: | ||
| raise ValueError(f"Unsupported value {label} for `label`." | ||
| " Must be 'right', 'left' or 'center'.") | ||
| if label is None: |
There was a problem hiding this comment.
users would need to pass label=None explicitly to trigger those checks but end up with label='right'. I think it's best to rely on the default handling.
I'll remove the label is None handling in degradation.py and plotting.py. I'll also update the tests that specifically trigger this. Commit 0fe8ebd
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return Rd_pct | ||
|
|
||
|
|
||
| def _avg_timestamp_old_Pandas(dt, dt_left): |
There was a problem hiding this comment.
With pandas three now released, should we think about dropping support for pandas 1.x.x?
There was a problem hiding this comment.
yeah, maybe we start with a deprecation warning for pandas < 2.0 in our next release. Pandas 2.0 was only put out in 2023 so we can probably hang on to this functionality for a few more years - its not really causing any harm. PVLib is still on pandas > 1.3.3 so we should probably still support it too...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… into multi_YoY_integration
…s passing `label=right` kwargs
|
@martin-springer - check out the example notebook with label='center' and multi_yoy=True functionality. |
@cdeline - It's looking great. The multi-yoy analysis really narrows down the distribution! Regarding the labelling:
|
…t the end of the multi-YoY notebook.
… into multi_YoY_integration
|
@cdeline - great, thank you for making those changes! |


See individual PR's #456, #460 and #464 for discussion.
Issues & PRs
__init__.py