Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
c8aae89
Matt’s updates to SRR algorithm (detect negative shifts in soiling ra…
Jun 24, 2024
e1401a6
committing updates to merge with aggregated_filters_for_trials
Jul 22, 2024
f23a497
Making sure there will be no merge conflicts
Jul 22, 2024
30f5548
Merge remote-tracking branch 'remotes/origin/aggregated_filters_for_t…
Jul 22, 2024
9e3a411
Improvements in order to pass checks and pytesting
Jul 31, 2024
9e3d89d
Merge pull request #417 from noromo01/development
martin-springer Aug 2, 2024
c08a0e9
Merge remote-tracking branch 'origin/aggregated_filters_for_trials' i…
martin-springer Aug 2, 2024
35a3ec9
formatting conftest.py and soiling_test.py
Aug 2, 2024
3fdf0b0
fixing formatting
Aug 5, 2024
669ec75
lint soiling.py
martin-springer Aug 6, 2024
23710a0
lint line length
martin-springer Aug 6, 2024
fa1d79b
revert TrendAnalysis notebook changes
martin-springer Aug 6, 2024
d642210
revert conftest.py
martin-springer Aug 6, 2024
9122b56
revert notebook requirements
martin-springer Aug 6, 2024
cd4fbb6
added piecewise and neg_shift PI data back to conftest.py
Aug 7, 2024
e9a2552
formatting fixes
Aug 8, 2024
612c9f1
minor formatting issue in soiling.py
Aug 10, 2024
0f020b5
testing some changes to pass notebook checks
Aug 13, 2024
6d5ce23
trying another minor change for notebook checks
Aug 13, 2024
b99c2de
soiling.py change to pass notebook checks
Aug 13, 2024
ab28608
Trying some changes in the notebooks to pass tests
Aug 16, 2024
2dbbeae
Fixing pytests and reverting notebooks
Aug 17, 2024
febe693
undoing some black formatting
Aug 19, 2024
ca7627b
cleaning up formatting redundancies in soiling_test.py
Aug 19, 2024
8b3fa4a
reformatting soiling.py and minor reformatting to soiling_test.py
Aug 19, 2024
efa5042
run black on soiling.py
martin-springer Aug 21, 2024
21da67d
fixing flake8 formatting
Aug 21, 2024
5ef6c81
fixing flake8 formatting
Aug 21, 2024
e66c295
removing _collapse_cleaning_events so half_norm_clean results are not…
Aug 21, 2024
628cfe8
fixing notebook failures
Aug 22, 2024
3860ada
Switching back code towards final review version
Aug 27, 2024
f64077a
fixing minor formatting
Aug 27, 2024
7517ddc
added fix for bare except and pytests for segmented_soiling_period fu…
Oct 24, 2024
cee6105
updated changelogs
Oct 24, 2024
9734118
Merge remote-tracking branch 'origin/aggregated_filters_for_trials' i…
Oct 24, 2024
cfd5858
deleted updates in wrong changelogs
Oct 24, 2024
6172ea0
fixed lint error
Oct 24, 2024
693c570
remove soiling experimental warning label
martin-springer Nov 6, 2024
b96ebcc
Merge branch 'development' into qnguyen345-bare_except_error
martin-springer Nov 6, 2024
e5159d7
update changelog
martin-springer Nov 6, 2024
fcac604
rerun notebooks
martin-springer Nov 6, 2024
6346480
Merge remote-tracking branch 'github-desktop-qnguyen345/bare_except_e…
martin-springer Nov 8, 2024
fd4dc47
fix double quotations left over from merge
martin-springer Nov 8, 2024
dc46cf6
remove double import
martin-springer Nov 8, 2024
8492873
remove experimental soiling warnings from plotting
martin-springer Nov 8, 2024
7df691c
remove warnings import
martin-springer Nov 8, 2024
b0c4510
quick fix mean runtimewarning
martin-springer Nov 8, 2024
48f02dc
re-run notebooks
martin-springer Nov 8, 2024
0299804
fix linting in soiling
martin-springer Nov 8, 2024
08e0090
update nbval and remove semicolons from nb's
martin-springer Nov 11, 2024
ec105a3
re-run notebooks
martin-springer Nov 11, 2024
5ded716
nbval update sanitize-with argument
martin-springer Nov 11, 2024
9b1fd4c
Merge branch 'development' into qnguyen345-bare_except_error
martin-springer Dec 12, 2024
a0a131f
Merge remote-tracking branch 'remotes/origin/master' into qnguyen345-…
cdeline Sep 16, 2025
af956a5
formatting and syntax changes
martin-springer Feb 4, 2026
3ce5572
attempt refactor
martin-springer Feb 5, 2026
54cf8fa
update soiling profiles
martin-springer Feb 5, 2026
99cad3f
Merge remote-tracking branch 'origin/development' into attempt_refact…
martin-springer Feb 5, 2026
892820d
Merge branch 'development' into attempt_refactor_soiling_pr
martin-springer Feb 12, 2026
a69d01b
fix refactor changes in tests
martin-springer Feb 12, 2026
3cc2926
create a pending changelog
martin-springer Feb 12, 2026
b996d42
fix pandas 2 vs 3 error
martin-springer Feb 12, 2026
0b15c65
remove changelog entries from v3.0.0 and added them to pending
martin-springer Feb 12, 2026
54a4df1
improve test coverage
martin-springer Feb 12, 2026
e3a3be6
fix segmented_soiling_period regression error
martin-springer Feb 12, 2026
04aab1a
draft notebook for soiling options
martin-springer Feb 12, 2026
87b9200
add the soiling options notebook to examples
martin-springer Feb 12, 2026
303326a
update the comparision notebook
martin-springer Feb 12, 2026
eccddb1
linting
martin-springer Feb 12, 2026
1fddd93
add soiling notebook to nbval
martin-springer Feb 12, 2026
c6afc14
Update rdtools/test/soiling_test.py
martin-springer Feb 12, 2026
d738909
Update rdtools/soiling.py
martin-springer Feb 12, 2026
474fd6d
Update rdtools/soiling.py
martin-springer Feb 12, 2026
b93d2c1
Update rdtools/test/soiling_test.py
martin-springer Feb 12, 2026
2fa047c
implement copilot suggestions
martin-springer Feb 12, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/nbval.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
'TrendAnalysis_example.ipynb',
'TrendAnalysis_example_NSRDB.ipynb',
'degradation_and_soiling_example.ipynb',
'soiling_options_guide.ipynb',
'system_availability_example.ipynb'
]

Expand All @@ -29,7 +30,7 @@ jobs:
- name: Run notebook and check output
run: |
# --sanitize-with: pre-process text to remove irrelevant differences (e.g. warning filepaths)
pytest --nbval docs/${{ matrix.notebook-file }} --sanitize-with docs/nbval_sanitization_rules.cfg
pytest --nbval --nbval-sanitize-with docs/nbval_sanitization_rules.cfg docs/${{ matrix.notebook-file }}
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow command uses --nbval-sanitize-with, but the repository docs (and the comment immediately above) reference nbval’s --sanitize-with option. With nbval>=0.10.0 in test dependencies, --nbval-sanitize-with is likely not a valid flag and would break the notebook CI job. Consider switching back to --sanitize-with docs/nbval_sanitization_rules.cfg (or updating the docs/comment and nbval requirement if this flag is intentional).

Suggested change
pytest --nbval --nbval-sanitize-with docs/nbval_sanitization_rules.cfg docs/${{ matrix.notebook-file }}
pytest --nbval --sanitize-with docs/nbval_sanitization_rules.cfg docs/${{ matrix.notebook-file }}

Copilot uses AI. Check for mistakes.
- name: Run notebooks again, save files
run: |
pip install nbconvert[webpdf]
Expand Down
831 changes: 279 additions & 552 deletions docs/TrendAnalysis_example.ipynb

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/TrendAnalysis_example_NSRDB.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
"ax.plot(df.index, df.soiling, 'o', alpha=0.01)\n",
"#ax.set_ylim(0,1500)\n",
"fig.autofmt_xdate()\n",
"ax.set_ylabel('soiling signal');\n",
"ax.set_ylabel('soiling signal')\n",
"df['power'] = df['power_ac'] * df['soiling']\n",
"\n",
"plt.show()"
Expand Down
14 changes: 8 additions & 6 deletions docs/degradation_and_soiling_example.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -93302,7 +93302,7 @@
},
{
"cell_type": "code",
"execution_count": 14,
"execution_count": 33,
"metadata": {
"execution": {
"iopub.execute_input": "2026-02-04T19:31:16.336479Z",
Expand Down Expand Up @@ -93618,6 +93618,8 @@
" <th>soiling_rate_high</th>\n",
" <th>inferred_start_loss</th>\n",
" <th>inferred_end_loss</th>\n",
" <th>inferred_recovery</th>\n",
" <th>inferred_begin_shift</th>\n",
" <th>length</th>\n",
" <th>valid</th>\n",
" </tr>\n",
Expand Down Expand Up @@ -93710,7 +93712,7 @@
"4 1.040835 4 False "
]
},
"execution_count": 22,
"execution_count": 41,
"metadata": {},
"output_type": "execute_result"
}
Expand Down Expand Up @@ -93938,7 +93940,7 @@
"11 7 "
]
},
"execution_count": 24,
"execution_count": 43,
"metadata": {},
"output_type": "execute_result"
}
Expand Down Expand Up @@ -94054,7 +94056,7 @@
"6 2016 0.970346 0.967108 0.973698"
]
},
"execution_count": 25,
"execution_count": 44,
"metadata": {},
"output_type": "execute_result"
}
Expand Down Expand Up @@ -94249,7 +94251,7 @@
"2010-03-01 00:00:00-07:00 0.838916 "
]
},
"execution_count": 28,
"execution_count": 47,
"metadata": {},
"output_type": "execute_result"
}
Expand Down Expand Up @@ -94369,7 +94371,7 @@
"metadata": {
"anaconda-cloud": {},
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"display_name": "rdtools3-nb",
"language": "python",
"name": "python3"
},
Expand Down
Loading
Loading