-
Notifications
You must be signed in to change notification settings - Fork 78
[WIP] Attempt refactor soiling pr #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
martin-springer
wants to merge
75
commits into
development
Choose a base branch
from
attempt_refactor_soiling_pr
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
c8aae89
Matt’s updates to SRR algorithm (detect negative shifts in soiling ra…
e1401a6
committing updates to merge with aggregated_filters_for_trials
f23a497
Making sure there will be no merge conflicts
30f5548
Merge remote-tracking branch 'remotes/origin/aggregated_filters_for_t…
9e3a411
Improvements in order to pass checks and pytesting
9e3d89d
Merge pull request #417 from noromo01/development
martin-springer c08a0e9
Merge remote-tracking branch 'origin/aggregated_filters_for_trials' i…
martin-springer 35a3ec9
formatting conftest.py and soiling_test.py
3fdf0b0
fixing formatting
669ec75
lint soiling.py
martin-springer 23710a0
lint line length
martin-springer fa1d79b
revert TrendAnalysis notebook changes
martin-springer d642210
revert conftest.py
martin-springer 9122b56
revert notebook requirements
martin-springer cd4fbb6
added piecewise and neg_shift PI data back to conftest.py
e9a2552
formatting fixes
612c9f1
minor formatting issue in soiling.py
0f020b5
testing some changes to pass notebook checks
6d5ce23
trying another minor change for notebook checks
b99c2de
soiling.py change to pass notebook checks
ab28608
Trying some changes in the notebooks to pass tests
2dbbeae
Fixing pytests and reverting notebooks
febe693
undoing some black formatting
ca7627b
cleaning up formatting redundancies in soiling_test.py
8b3fa4a
reformatting soiling.py and minor reformatting to soiling_test.py
efa5042
run black on soiling.py
martin-springer 21da67d
fixing flake8 formatting
5ef6c81
fixing flake8 formatting
e66c295
removing _collapse_cleaning_events so half_norm_clean results are not…
628cfe8
fixing notebook failures
3860ada
Switching back code towards final review version
f64077a
fixing minor formatting
7517ddc
added fix for bare except and pytests for segmented_soiling_period fu…
cee6105
updated changelogs
9734118
Merge remote-tracking branch 'origin/aggregated_filters_for_trials' i…
cfd5858
deleted updates in wrong changelogs
6172ea0
fixed lint error
693c570
remove soiling experimental warning label
martin-springer b96ebcc
Merge branch 'development' into qnguyen345-bare_except_error
martin-springer e5159d7
update changelog
martin-springer fcac604
rerun notebooks
martin-springer 6346480
Merge remote-tracking branch 'github-desktop-qnguyen345/bare_except_e…
martin-springer fd4dc47
fix double quotations left over from merge
martin-springer dc46cf6
remove double import
martin-springer 8492873
remove experimental soiling warnings from plotting
martin-springer 7df691c
remove warnings import
martin-springer b0c4510
quick fix mean runtimewarning
martin-springer 48f02dc
re-run notebooks
martin-springer 0299804
fix linting in soiling
martin-springer 08e0090
update nbval and remove semicolons from nb's
martin-springer ec105a3
re-run notebooks
martin-springer 5ded716
nbval update sanitize-with argument
martin-springer 9b1fd4c
Merge branch 'development' into qnguyen345-bare_except_error
martin-springer a0a131f
Merge remote-tracking branch 'remotes/origin/master' into qnguyen345-…
cdeline af956a5
formatting and syntax changes
martin-springer 3ce5572
attempt refactor
martin-springer 54cf8fa
update soiling profiles
martin-springer 99cad3f
Merge remote-tracking branch 'origin/development' into attempt_refact…
martin-springer 892820d
Merge branch 'development' into attempt_refactor_soiling_pr
martin-springer a69d01b
fix refactor changes in tests
martin-springer 3cc2926
create a pending changelog
martin-springer b996d42
fix pandas 2 vs 3 error
martin-springer 0b15c65
remove changelog entries from v3.0.0 and added them to pending
martin-springer 54a4df1
improve test coverage
martin-springer e3a3be6
fix segmented_soiling_period regression error
martin-springer 04aab1a
draft notebook for soiling options
martin-springer 87b9200
add the soiling options notebook to examples
martin-springer 303326a
update the comparision notebook
martin-springer eccddb1
linting
martin-springer 1fddd93
add soiling notebook to nbval
martin-springer c6afc14
Update rdtools/test/soiling_test.py
martin-springer d738909
Update rdtools/soiling.py
martin-springer 474fd6d
Update rdtools/soiling.py
martin-springer b93d2c1
Update rdtools/test/soiling_test.py
martin-springer 2fa047c
implement copilot suggestions
martin-springer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow command uses
--nbval-sanitize-with, but the repository docs (and the comment immediately above) reference nbval’s--sanitize-withoption. Withnbval>=0.10.0in test dependencies,--nbval-sanitize-withis likely not a valid flag and would break the notebook CI job. Consider switching back to--sanitize-with docs/nbval_sanitization_rules.cfg(or updating the docs/comment and nbval requirement if this flag is intentional).