Skip to content

Log a message when hitting a key that would have failed previously #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivakegg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Log a message when hitting a key that would have failed previously #251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c572e9
Log a message when hitting a key that would have failed previously
ivakegg Dec 30, 2025
cf522c0
spelling
ivakegg Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server/src/main/java/timely/server/store/MetricAgeOffIterator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,11 @@ private void handleNewMetricName(String metricName) {
*/
private byte[] ensureFollowing(byte[] topRow, byte[] newStart) {
if (WritableComparator.compareBytes(topRow, 0, topRow.length, newStart, 0, newStart.length) >= 0) {
// log a message so that we can determine how often this happens.
StringBuilder builder = new StringBuilder().append("Found a row in which the timestamp significantly differs from the encoded time: ");
Key.appendPrintableString(topRow, 0, topRow.length, topRow.length, builder);
log.warn(builder.toString());

byte[] followingRow = new byte[topRow.length + 1];
System.arraycopy(topRow, 0, followingRow, 0, topRow.length);
followingRow[topRow.length] = (byte) 0x00;
Expand Down