Skip to content

Update Bad Batch squads#42

Merged
NducTiOnomBi merged 1 commit intomainfrom
BadBatchV2Tweaks
Jan 2, 2026
Merged

Update Bad Batch squads#42
NducTiOnomBi merged 1 commit intomainfrom
BadBatchV2Tweaks

Conversation

@NducTiOnomBi
Copy link
Owner

Description

Improved Base, Synergy and Omicron distributions

Characters Affected

  • Bad Batch
  • Bad Batch S3

Validation Checklist

Local Testing:

  • [ x] Ran .\Tools\ValidateCharacterData.ps1 successfully
  • [ x] Ran .\Tools\ValidateCharacterData.ps1 -UseExternalValidator (if ajv-cli installed)
  • [ x] All validation checks passed locally

Data Integrity:

  • [ x] Characters are sorted alphabetically by ID
  • [ x] No duplicate character IDs
  • [x ] All baseTier values are between 1-19
  • [ x] All synergyEnhancement values are between 0-7
  • [ x] JSON formatting uses 2-space indentation
  • [x ] File saved with UTF-8 encoding (no BOM)

Schema Compliance:

  • [x ] All required fields (id, baseTier) are present
  • [x ] Character IDs follow format: uppercase letters/numbers/underscores only
  • [x ] Synergy sets include required synergyEnhancement or synergyEnhancementOmicron field
  • [x ] Category definitions include required include and numberMatchesRequired fields
  • [ x] numberMatchesRequired values are between 1-4

Testing (if applicable):

  • Exported data to Excel using ReadBaseDataToXLS.ps1
  • Verified tier placement visually in Excel
  • Checked synergy calculations using ReadBaseDataSynergyToXLS.ps1
  • Confirmed balance relative to similar characters

Additional Context


Deployment Notes

After this PR is merged to main:

  • ✅ Changes will automatically sync to Azure DevOps dev branch
  • ✅ Dev environment will be built and deployed automatically
  • ⚠️ IMPORTANT: Validate changes at https://dev-swgoh-stackrank-westus.azurewebsites.net/stackrank before production promotion
  • ℹ️ A comment will be posted on this PR with the deployment status and DEV URL

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

✅ Character Base Data Validation Passed

Validation Summary:

  • Total characters: 315
  • Characters with synergies: 277
  • Total synergy sets: 529

Tier Distribution:

  • Tier 2: 9 character(s)
  • Tier 3: 1 character(s)
  • Tier 4: 1 character(s)
  • Tier 5: 13 character(s)
  • Tier 6: 1 character(s)
  • Tier 7: 3 character(s)
  • Tier 8: 27 character(s)
  • Tier 9: 13 character(s)
  • Tier 10: 19 character(s)
  • Tier 11: 54 character(s)
  • Tier 12: 28 character(s)
  • Tier 13: 11 character(s)
  • Tier 14: 50 character(s)
  • Tier 15: 36 character(s)
  • Tier 16: 6 character(s)
  • Tier 17: 28 character(s)
  • Tier 18: 11 character(s)
  • Tier 19: 4 character(s)

All validation checks passed! The data is ready to be merged.


Once merged to main, this will trigger automatic deployment to the DEV environment in Azure.

@NducTiOnomBi NducTiOnomBi merged commit be251d9 into main Jan 2, 2026
1 check passed
@NducTiOnomBi NducTiOnomBi deleted the BadBatchV2Tweaks branch January 2, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant