Fix CELL_GCM_TEXTURE_A8R8G8B8 outputs’ reversed channels#17
Open
hydnhntr wants to merge 1 commit intoNenkai:masterfrom
Open
Fix CELL_GCM_TEXTURE_A8R8G8B8 outputs’ reversed channels#17hydnhntr wants to merge 1 commit intoNenkai:masterfrom
CELL_GCM_TEXTURE_A8R8G8B8 outputs’ reversed channels#17hydnhntr wants to merge 1 commit intoNenkai:masterfrom
Conversation
Owner
|
I don't completely remember why I added endian swap in the first place, but it must've been a good reason Namely I believed that the pixel components in the pixel buffers are in big-endian according to PPC in the first place, regardless of remap If you can, I would make sure that it works correctly across the majority of textures, namely i'd check GTHD, GT5P/5 and track textures |
Author
|
Small update after looking at GTHD Concept’s UI textures:
The uncompressed I’m unsure how to handle this, whether to rejig the data inside CreateDDSData() or whether Pfimage can be passed a stride. I also needed to remove the manual alignment above, as it was resulting in a mismatch in the expected length of data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

~/projects/gt5p/manual/GB/mage/gt5p/common/hot.dds~/projects/gt5p/arcade/GB/mage/gt5p/icon/icon_dealer.ddsCELL_GCM_TEXTURE_A8R8G8B8formatted TXS3 files were incorrectly output with their channels in reverse order.The values of
CELL_GCM_TEXTURE_REMAP_FROMlooked correct to me, so the individual channels were already being read in their intended byte order.I’m unsure what the manual endianness conversion was for, but with it removed
A8R8G8B8textures exported as expected. I don’t have an example ofCELL_GCM_TEXTURE_D8R8G8B8so don’t know if I’ve made a regression there 🫠