Make a separated package for clesh-test and revert some commits.#2
Make a separated package for clesh-test and revert some commits.#2daimrod wants to merge 6 commits intoNeronus:masterfrom
Conversation
|
Thanks for your alertness. I never use The !-syntax myself. I guess I should write some unit-tests for it :) Regarding the multiline-use of !, I doubt its actual usefulness. I guess it was an artifact of the old implementation. What do you think? I made those commits to unify the treatment of the escape-character. The policy is described in the README but can be summarized as follows: The use of the-only is probably a mistake. I don't know anymore what I thought when I introduced it. |
|
Oh yeah, regarding a separate package for testing: As I'm testing internals of clesh, and not only its external interface, I thought that it's useful to have it use the same package. |
|
Ooops, I was talking about this commit (the one where you introduce I think that there is no need to have multiline with Concerning a seperated package for testing, I don't know, just do as you whish. |
Conflicts: README.md clesh.lisp
|
I guess this issue is closed, isn't it? |
Hi, I've played a bit more with clesh and I think that there is a
problem with
this commit.
This doesn't work because of
THE-ONLY, I've reverted those commitsand it seems to work fine, though you cannot use multiline as you've
used them in the README.
This won't work because each line is expected to be a correct command
but the following snippet works:
This will run the two commands as expected.
I've also made a separated package for the unit-test though I don't
know if it's good, I just feel like it's better to have a bijection
between ASDF systems and packages.