This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Build ngraph-tf not only on Centos#396
Open
samolisov wants to merge 8 commits intoNervanaSystems:masterfrom
samolisov:build-not-only-on-centos
Open
Build ngraph-tf not only on Centos#396samolisov wants to merge 8 commits intoNervanaSystems:masterfrom samolisov:build-not-only-on-centos
samolisov wants to merge 8 commits intoNervanaSystems:masterfrom
samolisov:build-not-only-on-centos
Conversation
When ngraph-tf is being built on a 64-bits OS another than Centos,
the directory with libraries ('build/artifacts/lib64') could not be
found since CMakeLists.txt and *.cmake files make a reference to 'lib64'
if and only if the host OS is Centos:
if(OS_VERSION STREQUAL "\"centos\"")
But if the host OS is not Centos (SUSE for example), the condition is
always false and the 'lib' directory instead of 'lib64' will be
looked for. To fix the situation the condition is changed to something
similar to:
if(EXISTS ${NGRAPH_INSTALL_DIR}/lib64)
In order to create the right one of the 'build/install/lib64' or
'build/install/lib' directories, the 'GNUInstallDirs' CMake module is
used on the Linux platform (the idea is stolen from NGraph). The
'NGTF_INSTALL_LIB_DIR' option is set to
'${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}':
set(NGTF_INSTALL_LIB_DIR ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR})
Signed-off-by: Pavel Samolysov <samolisov@gmail.com>
avijit-nervana
suggested changes
Jan 18, 2019
Contributor
avijit-nervana
left a comment
avijit-nervana
left a comment
There was a problem hiding this comment.
What OSs you tested this (in addition to CentOS and Ubuntu)?
Since some 64-bits OS (Ubuntu Linux, anything else?) use 'lib' instead of 'lib64' to store libraries, the comment about 'lib64/lib' detection in the 'CreatePipWhl.cmake' file has been changed. Signed-off-by: Pavel Samolysov <samolisov@gmail.com>
Author
|
@avijit-nervana I've updates the comment. Could you please merge the PR if there is no concerns more? I'm working on OpenSUSE and making manual changing after each |
Author
|
@avijit-nervana What can we do to merge the PR? Do I have to sign any contribution agreement or something like this? |
|
Same problem on Manjaro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ngraph-tf is being built on a 64-bits OS another than Centos,
the directory with libraries ('build/artifacts/lib64') could not be
found since CMakeLists.txt and *.cmake files make a reference to 'lib64'
if and only if the host OS is Centos:
if(OS_VERSION STREQUAL ""centos"")
But if the host OS is not Centos (SUSE for example), the condition is
always false and the 'lib' directory instead of 'lib64' will be
looked for. To fix the situation the condition is changed to something
similar to:
if(EXISTS ${NGRAPH_INSTALL_DIR}/lib64)
In order to create the right one of the 'build/install/lib64' or
'build/install/lib' directories, the 'GNUInstallDirs' CMake module is
used on the Linux platform (the idea is stolen from NGraph). The
'NGTF_INSTALL_LIB_DIR' option is set to
'${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}':
set(NGTF_INSTALL_LIB_DIR ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR})
Signed-off-by: Pavel Samolysov samolisov@gmail.com