Add metrics to SingleThreadedChunker#740
Open
timmartin-stripe wants to merge 1 commit intoNetflix:masterfrom
Open
Add metrics to SingleThreadedChunker#740timmartin-stripe wants to merge 1 commit intoNetflix:masterfrom
timmartin-stripe wants to merge 1 commit intoNetflix:masterfrom
Conversation
Using a similar set of metrics to what the `TimedChunker` uses. It's helpful for diagnosing queue depth issues. When we switched to the SPSC queue, we were surprised the metrics were missing so I figured we could add them in.
timmartin-stripe
requested review from
Andyz26,
calvin681,
dtrager02,
fdc-ntflx and
hmitnflx
as code owners
Andyz26
approved these changes
Jan 8, 2025
| this.connectionManager = connMgr; | ||
| chunk = new Object[this.chunkSize]; | ||
|
|
||
| MetricGroupId metricsGroup = new MetricGroupId("SingleThreadedChunker"); |
Collaborator
There was a problem hiding this comment.
maybe add an index from ctor to help identify between threads.
| @@ -93,6 +115,7 @@ private void drain() { | |||
| } | |||
|
|
|||
| processor.process(connectionManager, copy); | |||
Collaborator
There was a problem hiding this comment.
i wonder if the "copy" list can be converted to be an immutable list.
timmartin-stripe
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Using a similar set of metrics to what the
TimedChunkeruses. It's helpful for diagnosing queue depth issues. When we switched to the SPSC queue, we were surprised the metrics were missing so I figured we could add them in.Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests