Initial impl to support marking TE as zombie#794
Draft
hellolittlej wants to merge 1 commit intomasterfrom
Draft
Conversation
Test Results306 tests - 355 300 ✅ - 350 7m 30s ⏱️ - 1m 37s Results for commit 3a91985. ± Comparison against base commit 8853a81. This pull request removes 355 tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Mantis has two layers heartbeat. One for container/node level, another is for worker/internal process level. For TE that lost heartbeat for over 30mins (a given threshold), we should mark it as permanently failure and terminate the instance + internal process. Because the master would reassign the worker to a different TE after worker heartbeat timeout, and if we don't remove the ghost instance, we would have two process running the task (one inside the ghost container, and another is reassigned by the master).
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests