[wip review]

[Andyz26]

No description provided.

[github-actions]

Test Results

161 files  +  8  161 suites  +8   10m 23s ⏱️ +58s
764 tests +100  753 ✅ +101  11 💤 ±0  0 ❌  - 1 
764 runs  + 99  753 ✅ +100  11 💤 ±0  0 ❌  - 1 

Results for commit 162f89a. ± Comparison against base commit 0e7ae19.

This pull request removes 13 and adds 113 tests. Note that renamed tests count towards both.

io.mantisrx.master.jobcluster.job.JobHeartbeatTimeoutTest ‑ testTimeUnitMismatchInHeartbeatCheck
io.mantisrx.master.jobcluster.job.JobHeartbeatTimeoutTest ‑ testWorkerStuckInLaunchedStateWithoutHeartbeat
io.mantisrx.master.jobcluster.job.JobHeartbeatTimeoutTest ‑ testWorkerWithStaleHeartbeat
io.mantisrx.master.jobcluster.job.JobScaleUpDownTests ‑ testJobScaleDown
io.mantisrx.master.jobcluster.job.JobScaleUpDownTests ‑ testJobScaleUp
io.mantisrx.master.jobcluster.job.JobScaleUpDownTests ‑ testJobScaleUpFailsIfMinEqualsMax
io.mantisrx.master.jobcluster.job.JobScaleUpDownTests ‑ testJobScaleUpFailsIfNoScaleStrategy
io.mantisrx.master.jobcluster.job.JobTestLifecycle ‑ testHeartBeatEnforcement
io.mantisrx.master.jobcluster.job.JobTestLifecycle ‑ testHeartBeatPendingSchedulingNoResubmit
io.mantisrx.master.jobcluster.job.JobTestLifecycle ‑ testJobSubmitPerpetual
…

io.mantisrx.master.jobcluster.job.JobActorReservationTests ‑ testInitialWorkersUseNewJobPriority
io.mantisrx.master.jobcluster.job.JobActorReservationTests ‑ testPriorityTierDerivedFromJobSla
io.mantisrx.master.jobcluster.job.JobActorReservationTests ‑ testReservationUpsertFailsAfterMaxRetries
io.mantisrx.master.jobcluster.job.JobActorReservationTests ‑ testReservationUpsertFailsAndRetriesWithBackoff
io.mantisrx.master.jobcluster.job.JobActorReservationTests ‑ testReservationUpsertSucceedsFirstAttempt
io.mantisrx.master.jobcluster.job.JobActorReservationTests ‑ testScaleUpUsesScalePriority
io.mantisrx.master.jobcluster.job.JobActorReservationTests ‑ testShutdownCancelsReservationsForEachStage
io.mantisrx.master.jobcluster.job.JobActorReservationTests ‑ testShutdownWithLegacySchedulingCallsUnscheduleJob
io.mantisrx.master.jobcluster.job.JobActorReservationTests ‑ testUpsertReservationContainsCorrectAllocationRequests
io.mantisrx.master.jobcluster.job.JobActorReservationTests ‑ testUpsertReservationContainsCorrectReservationKey
…

♻️ This comment has been updated with latest results.