Skip to content

feat(shasta): select derivation params based on chain id#892

Merged
mikhailUshakoff merged 6 commits intomasterfrom
mu/shasta-chain-id
Mar 6, 2026
Merged

feat(shasta): select derivation params based on chain id#892
mikhailUshakoff merged 6 commits intomasterfrom
mu/shasta-chain-id

Conversation

@mikhailUshakoff
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Shasta (and the permissionless node wrapper) to derive protocol/derivation parameters dynamically based on the connected chain ID, using Inbox config fetched from L1 and chain-specific constants from taiko_protocol.

Changes:

  • Replace fetch_protocol_config() with fetch_inbox_config() and derive ProtocolConfig inside Taiko::new() using the L2 chain ID.
  • Switch chain-dependent constants (e.g., max anchor/timestamp offsets, minimum base fee) to *_for_chain(chain_id) helpers.
  • Bump workspace version and update taiko-mono git dependencies/lockfile to a newer revision.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
shasta/src/lib.rs Fetches Inbox config from L1 and passes it into Taiko::new() instead of a prebuilt ProtocolConfig.
shasta/src/l2/taiko.rs Builds ProtocolConfig using L2 chain ID + Inbox config; uses chain-specific min base fee.
shasta/src/l2/execution_layer.rs Removes redundant stored chain_id and uses ExecutionLayerCommon::chain_id() instead.
shasta/src/l1/protocol_config.rs Makes ProtocolConfig::from chain-id aware via chain-specific constant helpers.
shasta/src/l1/execution_layer.rs Replaces fetch_protocol_config with fetch_inbox_config returning the raw Inbox config.
permissionless/src/lib.rs Mirrors Shasta’s node creation change to pass Inbox config into Taiko::new().
Cargo.toml Bumps workspace version and updates taiko_* git dependency revisions.
Cargo.lock Updates locked versions/sources to match the dependency and workspace version bumps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mikhailUshakoff mikhailUshakoff merged commit bbddec3 into master Mar 6, 2026
7 checks passed
@mikhailUshakoff mikhailUshakoff deleted the mu/shasta-chain-id branch March 6, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants