feat(shasta): select derivation params based on chain id#892
Merged
mikhailUshakoff merged 6 commits intomasterfrom Mar 6, 2026
Merged
feat(shasta): select derivation params based on chain id#892mikhailUshakoff merged 6 commits intomasterfrom
mikhailUshakoff merged 6 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Shasta (and the permissionless node wrapper) to derive protocol/derivation parameters dynamically based on the connected chain ID, using Inbox config fetched from L1 and chain-specific constants from taiko_protocol.
Changes:
- Replace
fetch_protocol_config()withfetch_inbox_config()and deriveProtocolConfiginsideTaiko::new()using the L2 chain ID. - Switch chain-dependent constants (e.g., max anchor/timestamp offsets, minimum base fee) to
*_for_chain(chain_id)helpers. - Bump workspace version and update
taiko-monogit dependencies/lockfile to a newer revision.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| shasta/src/lib.rs | Fetches Inbox config from L1 and passes it into Taiko::new() instead of a prebuilt ProtocolConfig. |
| shasta/src/l2/taiko.rs | Builds ProtocolConfig using L2 chain ID + Inbox config; uses chain-specific min base fee. |
| shasta/src/l2/execution_layer.rs | Removes redundant stored chain_id and uses ExecutionLayerCommon::chain_id() instead. |
| shasta/src/l1/protocol_config.rs | Makes ProtocolConfig::from chain-id aware via chain-specific constant helpers. |
| shasta/src/l1/execution_layer.rs | Replaces fetch_protocol_config with fetch_inbox_config returning the raw Inbox config. |
| permissionless/src/lib.rs | Mirrors Shasta’s node creation change to pass Inbox config into Taiko::new(). |
| Cargo.toml | Bumps workspace version and updates taiko_* git dependency revisions. |
| Cargo.lock | Updates locked versions/sources to match the dependency and workspace version bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mskrzypkows
approved these changes
Mar 6, 2026
PoulavBhowmick03
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.